Skip to content

Error in _sample_orthonormal_to #33

@saurabhsharma1993

Description

@saurabhsharma1993

In line 55 in spherecluster/util.py, in the _sample_orthonormal_to function, it reads:

proj_mu_v = mu * np.dot(mu, v) / np.linalg.norm(mu)

Shouldn't it instead be:

proj_mu_v = mu * np.dot(mu, v) / np.linalg.norm(mu)**2

If norm(mu)=1 then it doesn't make a difference, but otherwise they are quite different.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions