Scheduled func will return false when a DoSafely function is used

[prassag]

The DoSafely function hides the function name (jobFun) so the function written to the job is always the wrapper recoveryWrapperFunc.

[Streppel]

Thank you for taking the time to let us know @prassag! I believe we might consider stripping out the DoSafely function altogether in the near future and stop bubbling panics from inside the code instead. Correct error handling is coming up in a new branch that will be merged as soon as we finish conflicts

[preslavrachev]

Sad to see the DoSafely function causing so many issues. I might try to revise it an come up with a quick fix over the weekend.

@Streppel I am not sure that preventing panics in 100% of the cases (if I understood you correctly) is the safest solution. There may be many situations, in which a run-time panic may cause the application to continue in a broken state. In such situations, a clean app restart works best, or some sort of state cleanup is needed. The idea behind DoSafely was that the caller would consciously use it over Do and accept such possible risks.

That's why, even when wrapping the panic, IMHO, a custom error needs to be propagated back to the caller. Whoever sets up the scheduled jobs needs to have some possibility of writing custom error handling code.

[Streppel]

@preslavrachev absolutely Preslav! I'm not saying we will stop preventing panics, what I meant is that we will stop propagating panics deliberately from within the code, so we can keep the panic detection and handling inside the bare Do function instead of another one (say DoSafely). I mean, that's the main reason why DoSafely was implemented as another function, right? As there were panics being called directly on the code in case of simple errors.

I believe this is our chance to review how this feature could be better implemented. There will be a merge in a few days which will deprecate DoSafely and thus we can focus on working directly on Do then :) what do you say?

[JohnRoesler]

@preslavrachev and others, come checkout the fork we're maintaining https://github.com/go-co-op/gocron