checkpoint - solved most issues

Author: jasonsiders

force-app/main/default/classes/DatabaseLayer.cls

@@ -5,19 +5,17 @@ public class DatabaseLayer {
 	 * Use the `Dml` and `Soql` static properties to get the correct instance of each.
 	 * Automatically inject mock versions of these classes via the `useMocks()` method.
 	 **/
-	// **** CONSTANTS **** //
 	public static final DatabaseLayerUtils UTILS;
 	private static final DatabaseLayer INSTANCE;
 
+	private Dml currentDml;
+	private SoqlProvider currentSoql;
+
 	static {
 		INSTANCE = new DatabaseLayer();
 		UTILS = new DatabaseLayerUtils(INSTANCE);
 	}
 
-	// **** MEMBER **** //
-	private Dml currentDml;
-	private SoqlProvider currentSoql;
-
 	private DatabaseLayer() {
 		this.currentDml = new Dml(this);
 		this.currentSoql = new SoqlProvider(this);

force-app/main/default/classes/DatabaseLayerTestUtils.cls

@@ -1,4 +1,4 @@
-@SuppressWarnings('PMD.ApexDoc')
+@SuppressWarnings('PMD.ApexDoc,PMD.FieldNamingConventions,PMD.UnusedLocalVariable')
 @IsTest
 public class DatabaseLayerTestUtils {
 	public static final PreAndPostProcessorSpy DmlPluginSpy = new PreAndPostProcessorSpy();

force-app/main/default/classes/Dml.cls

@@ -1,5 +1,5 @@
 @SuppressWarnings(
-	'PMD.ApexDoc,PMD.CognitiveComplexity,PMD.CyclomaticComplexity,PMD.EmptyStatementBlock,PMD.ExcessiveParameterList,PMD.ExcessivePublicCount'
+	'PMD.ApexDoc,PMD.CognitiveComplexity,PMD.CyclomaticComplexity,PMD.EmptyStatementBlock,PMD.ExcessiveParameterList,PMD.ExcessivePublicCount,PMD.FieldNamingConventions'
 )
 public inherited sharing virtual class Dml {
 	/**

force-app/main/default/classes/MockDml.cls

@@ -620,7 +620,7 @@ public class MockDml extends Dml {
 		public String name { get; private set; }
 		public Boolean wasReleased { get; private set; }
 		public Boolean wasRolledBack { get; private set; }
-		private transient MockDml.Database savepointState;
+		private transient MockDml.Database savepointState { get; private set; }
 
 		private Savepoint(System.Savepoint savepoint, Integer index) {
 			this.index = index;

force-app/main/default/classes/MockRecord.cls

@@ -17,6 +17,7 @@ public class MockRecord {
 	private transient SObjectType objectType;
 	private transient Map<String, Object> recordValues;
 
+	@SuppressWarnings('PMD.PropertyNamingConventions')
 	public Id Id {
 		get {
 			// Mirrors standard SObject functionality; all SObject records have an Id property - even untyped!
@@ -221,8 +222,9 @@ public class MockRecord {
 	private class RelatedList {
 		// Represents a child object relationship retrieved by SOQL.
 		// This structure is required when mocking related lists on an SObject
-		// ** Members
 		private Boolean done;
+		private transient List<MockRecord> mockRecords;
+		private transient List<SObject> realRecords;
 		private List<SObject> records {
 			get {
 				return this.getRecords();
@@ -233,9 +235,6 @@ public class MockRecord {
 				return this.getSize();
 			}
 		}
-		// ** Transient
-		private transient List<MockRecord> mockRecords;
-		private transient List<SObject> realRecords;
 
 		private RelatedList() {
 			this.done = true;

force-app/main/default/classes/MockSoqlTest.cls

@@ -1,4 +1,4 @@
-@SuppressWarnings('PMD.ApexDoc,PMD.ApexUnitTestClassShouldHaveRunAs')
+@SuppressWarnings('PMD.ApexDoc,PMD.ApexUnitTestClassShouldHaveRunAs,PMD.CyclomaticComplexity')
 @IsTest
 private class MockSoqlTest {
 	// **** CONSTANTS **** //

force-app/main/default/classes/Soql.cls

@@ -902,7 +902,7 @@ public inherited sharing virtual class Soql extends Soql.Builder {
 		}
 	}
 
-	@SuppressWarnings('PMD.ExcessiveParameterCount')
+	@SuppressWarnings('PMD.ExcessiveParameterList')
 	public class ParentField implements Soql.Selectable {
 		// Represents a reference to a SObjectField on a parent (or multi-grandparent) object, ex., "Account.Owner.Profile.Name"
 		// SOQL supports querying fields objects up to 5 relationships away from the FROM object
@@ -1011,9 +1011,8 @@ public inherited sharing virtual class Soql extends Soql.Builder {
 		public Boolean isMockSoql { get; protected set; }
 		public Soql.Operation operation { get; private set; }
 		public Soql query { get; private set; }
-		protected transient System.AccessLevel accessLevel;
-		protected transient Map<String, Object> binds;
-		// ** Getters:
+		protected transient System.AccessLevel accessLevel { get; private set; }
+		protected transient Map<String, Object> binds { get; private set; }
 		public String queryString {
 			get {
 				return this.query?.toString();