Would it be possible to populate a state hash?

[felipecrs]

Hi,

I need to track whether the state of any LED changed in OpenRGB:

• https://github.com/home-assistant/core/pull/154732/files/e54ecbe4420a2e52b5900916b412d4aeda457058#diff-693fda17f02bb829a7372311e8ade10ee18fc5b6cd9efae4430220921e1a898bR54-R63

However, that operation is rather costly.

Could openrgb-python provide this information when updating the state?

When the state is received from the OpenRGB SDK server you already iterate through it (I think), so computing a hash of the state would likely be cheaper than re-checking everything later.

Even a hash might be overkill. A potentially cheaper approach could be to sum the RGB values for each LED visited and combine that with the current profile, brightness, speed, etc., producing a small checksum I can compare on updates.

[jath03]

As mentioned in the PR, it seems like this is not really necessary so I'm closing.

When the state is received from the OpenRGB SDK server you already iterate through it (I think), so computing a hash of the state would likely be cheaper than re-checking everything later.

The fastest python code is C. I bet it would be difficult to write a minimal hash in python that would be faster than a builtin like hash that I assume is a fairly optimized C function at its core. I'm not even sure the checksum you mentioned would be significantly faster because it would add a not completely trivial # of new python lines to the data parsing, even if they would be simple lines. I'm almost curious enough to implement this just to benchmark it, but not quite.

[felipecrs]

Alright. Thanks a lot!

I'm almost curious enough to implement this just to benchmark it, but not quite.

🤣

---

PS: The PR referred is #87.