Merge pull request #45 from valentine195:valentine195/issue44

`collapse:` no longer defaults to closed

Author: valentine195

manifest.json

@@ -1,7 +1,7 @@
 {
     "id": "obsidian-admonition",
     "name": "Admonition",
-    "version": "5.0.2",
+    "version": "5.0.3",
     "minAppVersion": "0.11.0",
     "description": "Admonition block-styled content for Obsidian.md",
     "author": "Jeremy Valentine",

package.json

@@ -1,6 +1,6 @@
 {
     "name": "obsidian-admonition",
-    "version": "5.0.2",
+    "version": "5.0.3",
     "description": "Admonition block-styled content for Obsidian.md",
     "main": "main.js",
     "scripts": {

src/util/util.ts

@@ -79,8 +79,7 @@ export function getParametersFromSource(type: string, src: string) {
      * If the admonition should collapse, but something other than open or closed was provided, set to closed.
      */
     if (
-        collapse &&
-        collapse.length &&
+        collapse !== undefined &&
         collapse !== "none" &&
         collapse !== "open" &&
         collapse !== "closed"
@@ -91,12 +90,7 @@ export function getParametersFromSource(type: string, src: string) {
     /**
      * If the admonition should collapse, but title was blanked, set the default title.
      */
-    if (
-        title.trim() === "" &&
-        collapse &&
-        collapse.length &&
-        collapse !== "none"
-    ) {
+    if (title.trim() === "" && collapse !== undefined && collapse !== "none") {
         title = type[0].toUpperCase() + type.slice(1).toLowerCase();
         new Notice("An admonition must have a title if it is collapsible.");
     }

versions.json

@@ -10,5 +10,5 @@
     "4.2.1": "0.11.0",
     "4.3.1": "0.12.0",
     "4.4.2": "0.12.2",
-    "5.0.2": "0.12.2"
+    "5.0.3": "0.12.2"
 }