Found a strange bug when adding a leap day

[xXPowerProXx]

Check for existing bug reports before submitting.

• I searched for existing Bug Reports and found no similar reports.

Expected Behavior

While using Calendarium regularly, I've encountered a peculiar bug: when adding a leap day, I expect the "absolute day counter" to remain unchanged.

Current behaviour

However, this only turns out to be incorrect when the month CHANGES.

Reproduction

Let me explain better by reproducing an example:

1. Create any calendar.
2. For explanatory purposes, I'll use the Gregorian calendar.
3. Edit the calendar from the "Open Custom Creator" btn.
4. Then, from Dates, scroll down to Leap Days.
5. Create a new leap day for the month of February.
6. Select the "intercalary" checkbox and set any number before the last day of the month
   (it can also be the last day, but for explanatory purposes, I'll set a different day from the last).
7. The day conditions are irrelevant: just set an annual repetition.
8. Save and open the calendar.
9. Select the yearly view and move to the previous year (2024) in February.
10. Select "Show day number."
11. Select 2-3 days before the leap day you set.
12. From the window that appears read the current day number and start advancing the days.

You will see that both the default leap day and the new leap day are counted correctly, BUT when you get to the 1st day of the month, it is counted as the same day as the last day of the previous month: it has not advanced by 1 day.
This means that one day has not been counted. Which one? Just move forward one year to see that the day it's the one with the “intercalary” option (the day we added earlier).
So, the leap “intercalary” day is simultaneously counted by the month in which it is found, and ignored by the following months of that year.

It is essential to note that this also happens with months with the “intercalary” option: the internal count is basically thrown off.

From there, I continued to investigate further to understand how it would affect the plugin, and apparently both the lunar cycles and the weather, which I deduce are based on the absolute value of days, are being distorted. (If you'd like, I can open a separate ticket just for these two)

The problem in short is that:
The internal system for counting absolute days does not correctly take into account “intercalary” options, only temporarily counting them in the month in which they occur.

Which Operating Systems are you using?

• Android
• iPhone/iPad
• Linux
• macOS
• Windows

Obsidian Version Check

1.10.3 and 1.8.4

Plugin Version

2.1.0

Confirmation

• I have disabled all other plugins and the issue still persists.

Possible solution

No response

[dequbed]

Oh fun, I think this is the same bug as what I encountered and for which I sent my old fixes in as #227 just now. If you have the setup for it you could try if this bug is fixed if you use the branch with the fixes, if not, no worries.