make Category.slug unique

Author: PetrDlouhy

README.rst

@@ -13,6 +13,12 @@ Django Categories grew out of our need to provide a basic hierarchical taxonomy
 
 As a news site, our stories, photos, and other content get divided into "sections" and we wanted all the apps to use the same set of sections. As our needs grew, the Django Categories grew in the functionality it gave to category handling within web pages.
 
+=======
+New in 2.0
+==========
+
+*  Category.slug becomes unique. You must remove all duplicates in category slugs before running migrations.
+
 New in 1.4
 ==========
 

categories/base.py

@@ -44,7 +44,7 @@ class CategoryBase(MPTTModel):
         verbose_name=_('parent'),
     )
     name = models.CharField(max_length=100, verbose_name=_('name'))
-    slug = models.SlugField(verbose_name=_('slug'))
+    slug = models.SlugField(verbose_name=_('slug'), unique=True)
     active = models.BooleanField(default=True, verbose_name=_('active'))
 
     objects = CategoryManager()

categories/fixtures/musicgenres.json

@@ -2292,7 +2292,7 @@
 	    "name": "Country pop",
 	    "parent": 142,
 	    "level": 1,
-	    "slug": "country-pop",
+	    "slug": "country-pop1",
 	    "lft": 100,
 	    "tree_id": 10,
 	    "order": 1

categories/migrations/0003_auto_20181005_1559.py

@@ -0,0 +1,18 @@
+# Generated by Django 2.0.9 on 2018-10-05 13:59
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('categories', '0002_auto_20170217_1111'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='category',
+            name='slug',
+            field=models.SlugField(unique=True, verbose_name='slug'),
+        ),
+    ]

categories/tests/test_category_import.py

@@ -57,7 +57,7 @@ def testMixingTabsSpaces(self):
         Should raise an exception.
         """
         string1 = ["cat1", "    cat1-1", "\tcat1-2-FAIL!", ""]
-        string2 = ["cat1", "\tcat1-1", "    cat1-2-FAIL!", ""]
+        string2 = ["cat2", "\tcat2-1", "    cat2-2-FAIL!", ""]
         cmd = Command()
 
         # raise Exception

categories/tests/test_models.py

@@ -2,6 +2,7 @@
 
 from django.core.files import File
 from django.core.files.uploadedfile import UploadedFile
+from django.db.utils import IntegrityError
 
 from categories.models import Category
 from django.test import TestCase
@@ -19,3 +20,8 @@ def test_thumbnail(self):
             self.assertEqual(category.pk, 1)
             self.assertEqual(category.thumbnail_width, 640)
             self.assertEqual(category.thumbnail_height, 480)
+
+    def test_duplicate_slug_fail(self):
+        Category.objects.create(name='Test Category', slug='test-category')
+        with self.assertRaises(IntegrityError):
+            Category.objects.create(name='Test Category1 ', slug='test-category')