Version 3.1.0 corrupting sourceURL index maps and producing broken javascript

[longhotsummer]

Version 3.1.0 of django-pipeline looks like it is producing JS which isn't valid.

My input JS file has code like this (initial contents of eval() removed for simplicity):

eval("... return range;\n}\n//# sourceMappingURL=index.js.map\n\n//# sourceURL=webpack://indigo/./node_modules/dom-anchor-text-position/lib/index.js?");

That is being transformed by django-pipeline into this (note the /# sourceURL at the end should be //# but is now /#):

eval("... return range;\n}\n//# sourceMappingURL=lib/index.js.map\n\n/# sourceURL=webpack:/indigo/node_modules/dom-anchor-text-position/lib/index.js?");

The problem is that /# is now interpreted as a regular expression, not as a comment, which causes the call to eval() to fail, because it's not a valid regex:

/# sourceURL=webpack:/indigo/node_modules/dom-anchor-text-position/lib/index.js?

Reverting to 3.0.0 fixes the problem.

• Here is my input file: https://github.com/laws-africa/indigo/blob/master/indigo_app/static/lib/external-imports.js
• Here is my pipeline config: https://github.com/laws-africa/indigo/blob/master/indigo/settings.py#L288

[tomka]

We encounter a related problem: we use the numjs library and the source mapping URL rewrites introduced in fd1c033 (#808) break its JavaScript file, both the regular one and the minified version: On line 17784 of numjs sources have:

var sourceURL = '//# sourceURL=' +

This gets replaced by django-pipeline with

var sourceURL = '//# sourceURL=../../libs/numjs/' +

In the minified version, which we usually use, a second problem arises in addition to that, which results in breaking the whole library. django-pipeline replaces

var n=o("path"),e=o("./read"),t=n.join(n.resolve(r),"./data");

with

var n=o("path"),e=o("./read"),t=n.join(n.resolve(r),"../../data");

This is probably due to the first match of sourceURL and everyting being on a single line.

My configuration for this package in django-pipeline looks like this:

{
  'source_filenames': 'libs/numjs/numjs.min.js',
  'output_filename': 'js/libs/numjs-lib.js'
}

Is there a way of fixing this without downgrading to 3.0.0 (because we want to e.g. use new Django versions)?

Maybe it would be helpful if this rewriting can be enabled/disabled per package or at least skip sourceURL assignments that are inside quotes (i.e. are a string)?