Skip to content

Foreign key resolves to parent class when using abstract models #437

Open
@mcovalt

Description

@mcovalt

Problem
Foreign key lookups don't upcast to their actual type when a parent polymorphic model inherits from an abstract base class. This is inconsistent with the behavior described here.

Example:

from django.db import models
from polymorphic.models import PolymorphicModel

class CommonInfo(models.Model):
    class Meta:
        abstract = True

class Parent(CommonInfo, PolymorphicModel):
    fk = models.ForeignKey("self", on_delete=models.CASCADE, null=True)

class Child(Parent):
     field = models.CharField(max_length=10)


related_obj = Child.objects.create(field="related child")
obj = Child.objects.create(fk=related_obj, field="child")
obj.refresh_from_db()
type(obj.related_obj) == Child    # False
type(obj.related_obj) == Parent   # True

A PR with a failing test has been made: #438

Resolution
Adding base_manager_name = "objects" to CommonInfo.Meta resolves the issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions