Skip to content

MenuItem's kwargs should be checked to be callable #83

Open
@nerdoc

Description

@nerdoc

As stated in #78, MenuItem's __init__() adds all additionally added kwargs as instance variables. This is great for new args lico icon etc., as long as they are "static", meaning they do not change over time in the template's context.
There are many variables I can think of (even icon!) like

  • badge (which should return e.g. a number of new emails), or
  • disabled (which should be true if a certain condition is met)
  • ...

where you would need to add it to MenuItem, and it would be easy with kwargs, but MenuItem doesn't check if it is callable.

So I would propose to

  1. put kwargs in a dict self.kwargs to have a reference later
  2. nstead of making reference vars of them in the first place, do this after 1., to hold the same reference. Please correct me if this is not correct in Python...
    (untested, just as idea here)
def __init__(..., **kwargs)
    # ...
    self.kwargs = kwargs
    # keep a link of all kwargs in the instance, for convenience/template context
    for k in self.kwargs:
        setattr(self, k, self.kwargs[k])    

def process(self, request):
    # ...
    # if kwargs are callable, call them and save the results in the actual instance variables
    for key, value in self.kwargs:
        if callable(value):
            setattr(self, k, self.kwargs[k]())    

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementSomething can be improved

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions