get all phonedevices of the user (fixes #659)

Author: jpaniagualaconich

two_factor/plugins/phonenumber/method.py

@@ -4,12 +4,12 @@
 
 from .forms import PhoneNumberForm
 from .models import PhoneDevice
-from .utils import backup_phones, format_phone_number, mask_phone_number
+from .utils import format_phone_number, mask_phone_number
 
 
 class PhoneMethodBase(MethodBase):
     def get_devices(self, user):
-        return [device for device in backup_phones(user) if device.method == self.code]
+        return PhoneDevice.objects.filter(user=user, method=self.code)
 
     def recognize_device(self, device):
         return isinstance(device, PhoneDevice) and device.method == self.code

two_factor/plugins/phonenumber/tests/__init__.py

@@ -0,0 +1,24 @@
+from django.test import TestCase
+
+from tests.utils import UserMixin
+from two_factor.plugins.phonenumber.method import PhoneCallMethod, SMSMethod
+
+
+class PhoneMethodBaseTestMixin(UserMixin):
+    def test_get_devices(self):
+        other_method_code = PhoneCallMethod.code if isinstance(self.method, SMSMethod) else SMSMethod.code
+        user = self.create_user()
+        backup_device = user.phonedevice_set.create(name='backup', number='+12024561111', method=self.method.code)
+        default_device = user.phonedevice_set.create(name='default', number='+12024561111', method=self.method.code)
+        user.phonedevice_set.create(name='default', number='+12024561111', method=other_method_code)
+
+        method_device_pks = [device.pk for device in self.method.get_devices(user)]
+        self.assertEqual(method_device_pks, [backup_device.pk, default_device.pk])
+
+
+class PhoneCallMethodTest(PhoneMethodBaseTestMixin, TestCase):
+    method = PhoneCallMethod()
+
+
+class SMSMethodTest(PhoneMethodBaseTestMixin, TestCase):
+    method = SMSMethod()