Make pip-sync honor src_files from the config file - #2433
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
pip-compile reads src_files out of the click context default_map when none are given on the command line, but pip-sync never did, so [tool.pip-tools.sync] src_files was silently ignored and pip-sync always fell back to requirements.txt (or exited 2 when it was absent). Apply the same default_map lookup in pip-sync. CLI arguments still win. Fixes jazzband#2187
psf-chronographer
Bot
added
the
bot:chronographer:provided
Member
|
I'm not clear on whether or not this is desirable behavior.
[tool.pip-tools]
src-files = ["pyproject.toml"]Such a config is very clearly meant for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2187
pip-compilereadssrc_filesout of the click contextdefault_mapwhen none are given on the command line, butpip-syncnever did — so[tool.pip-tools.sync] src_fileswas silently ignored andpip-syncalways fell back torequirements.txt(or exited 2 when it was absent). This applies the same lookup inpip-sync; CLI arguments still take precedence.Contributor checklist
changelog.d/(seechangelog.d/README.mdfor instructions) or the PR text says "no changelog needed".
Maintainer checklist
bot:chronographer:skiplabel.(following Semantic Versioning).