Error when file modification dates are old

[rch7]

It has problem with old file modification dates. E.g.

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----          1/6/1929  12:00 AM        3813558 1929-01-06-1 - ***********************************.jpg

[INFO] Copying copy tree
C:\Nuotraukos\Senos2\1929-01-06-1 - ***********************************..jpg: 1 file pushed, 0 skipped. 20.1 MB/s (3813558 bytes in 0.181s)
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\rch\AppData\Roaming\Python\Python313\Scripts\adbsync.exe\__main__.py", line 7, in <module>
    sys.exit(main())
             ~~~~^^
  File "C:\Users\rch\AppData\Roaming\Python\Python313\site-packages\BetterADBSync\__init__.py", line 510, in main
    fs_destination.push_tree_here(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        path_source,
        ^^^^^^^^^^^^
    ...<5 lines>...
        show_progress = args.show_progress
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "C:\Users\rch\AppData\Roaming\Python\Python313\site-packages\BetterADBSync\FileSystems\Base.py", line 91, in push_tree_here
    self.push_tree_here(
    ~~~~~~~~~~~~~~~~~~~^
        fs_source.normpath(fs_source.join(tree_path, key)),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<5 lines>...
        show_progress = show_progress
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "C:\Users\rch\AppData\Roaming\Python\Python313\site-packages\BetterADBSync\FileSystems\Base.py", line 91, in push_tree_here
    self.push_tree_here(
    ~~~~~~~~~~~~~~~~~~~^
        fs_source.normpath(fs_source.join(tree_path, key)),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<5 lines>...
        show_progress = show_progress
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "C:\Users\rch\AppData\Roaming\Python\Python313\site-packages\BetterADBSync\FileSystems\Base.py", line 81, in push_tree_here
    self.utime(destination_root, tree)
    ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\rch\AppData\Roaming\Python\Python313\site-packages\BetterADBSync\FileSystems\Android.py", line 184, in utime
    mtime = datetime.datetime.fromtimestamp(times[1]).strftime("%Y%m%d%H%M")
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^
OSError: [Errno 22] Invalid argument

The resulting file is created with 2106-02-07 01:28 date. You can set old dates in Android through adb, e.g.:

PS C:\Users\rch> C:\SamFwTool\data\adb.exe shell touch -d 1929-01-06 '/storage/emulated/0/Nuotraukos/Senos2/1929-01-06*'
PS C:\Users\rch> C:\SamFwTool\data\adb.exe shell ls -l '/storage/emulated/0/Nuotraukos/Senos2/1929-01-06*'
-rw-rw---- 1 u0_a263 media_rw 3813558 1929-01-06 00:00 /storage/emulated/0/Nuotraukos/Senos2/1929-01-06-1 - **********************.jpg

[lordofda]

I have similar problem, do not know if it is also timestamp data related:

PS C:\Users\lordo> adbsync -v --show-progress pull "******" "********"
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Python311\Scripts\adbsync.exe\__main__.py", line 7, in <module>
  File "C:\Python311\Lib\site-packages\BetterADBSync\__init__.py", line 374, in main
    files_tree_source = fs_source.get_files_tree(path_source, follow_links = args.copy_links)
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\BetterADBSync\FileSystems\Base.py", line 45, in get_files_tree
    return self._get_files_tree(tree_path, statObject, follow_links = follow_links)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\BetterADBSync\FileSystems\Base.py", line 33, in _get_files_tree
    tree[filename] = self._get_files_tree(
                     ^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\BetterADBSync\FileSystems\Base.py", line 30, in _get_files_tree
    for filename, stat_object_child, in self.lstat_in_dir(tree_path):
  File "C:\Python311\Lib\site-packages\BetterADBSync\FileSystems\Android.py", line 180, in lstat_in_dir
    yield self.ls_to_stat(line)
          ^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\BetterADBSync\FileSystems\Android.py", line 131, in ls_to_stat
    st_mtime = int(datetime.datetime.strptime(match_groupdict["st_mtime"], "%Y-%m-%d %H:%M").timestamp())
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 22] Invalid argument

[jpstotz]

This seems to be a Windows specific limitation, see here: https://stackoverflow.com/questions/62006433/python3-fromtimestamp-generates-oserror

You can try to modify the source code as mentioned in the linked Stackoverflow question

better-adb-sync/src/BetterADBSync/FileSystems/Android.py

Lines 182 to 186 in 2d19f23

	def utime(self, path: str, times: Tuple[int, int]) -> None:
	atime = datetime.datetime.fromtimestamp(times[0]).strftime("%Y%m%d%H%M")
	mtime = datetime.datetime.fromtimestamp(times[1]).strftime("%Y%m%d%H%M")
	for line in self.adb_shell(["touch", "-at", atime, "-mt", mtime, path]):
	self.line_not_captured(line)

Change e.g. datetime.datetime.fromtimestamp(times[0]).strftime("%Y%m%d%H%M") to (datetime.datetime(1970, 1, 1) + datetime.timedelta(seconds=times[0])).strftime("%Y%m%d%H%M") similar the next line.

[jpstotz]

I have created a fork that includes the necessary changes: https://github.com/jpstotz/better-adb-sync
See it's readme how to install it.

The fun part is that setting the file date on PC side was broken anyway as it was designed for Python 2 and failed silently on Python 3. Therefore all those parsed file dates were in the end ignored...

On Windows files with a date before 1970 still make problems, as Explorer will only show an empty date value in the file date column, but the pull operation will work.