Skip to content

Crash when filename contains a newline character #56

@helpimnotdrowning

Description

@helpimnotdrowning

When initially enumerating the files at the given path (I am pulling, so for me its coming from /storage/emulated/0), it kept crashing with the line

[ERROR] Failed to parse ADB output line: .apk (Android.py:147)

This is because ffupdater, an app to deliver updates for "privacy-friendly" browsers, downloaded a file named (lit.)

CROMITE_MTQwLjAuNzMzOS44MSA=
.apk

to /storage/emulated/0/Android/data/de.marmaro.krt.ffupdater/files/Download/.

adbsync finds filenames using the ls -la command over adb shell. When I manually list the directory, it prints this:

total 278930
drwxrws--- 2 u0_a509 ext_data_rw      3452 2025-09-10 20:47 .
drwxrws--- 3 u0_a509 ext_data_rw      3452 2025-08-10 15:06 ..
-rw-rw---- 1 u0_a509 ext_data_rw  28752664 2025-08-25 04:03 1a768069-c427-43c2-84de-85c7cce4ffb7zip
-rw-rw---- 1 u0_a509 ext_data_rw  12778250 2025-09-08 23:36 4bb0ed23-b560-4644-b0f0-dc9fa7802d5ezip
-rw-rw---- 1 u0_a509 ext_data_rw  15891231 2025-08-30 10:53 7cbc0548-79e9-4ac9-bf98-f0a299733b6czip
-rw-rw---- 1 u0_a509 ext_data_rw   8174360 2025-08-21 19:46 99981eb2-52ce-46c8-8829-61c50928738azip
-rw-rw---- 1 u0_a509 ext_data_rw 151714729 2025-09-06 13:53 CROMITE_MTQwLjAuNzMzOS44MSA=
.apk
-rw-rw---- 1 u0_a509 ext_data_rw   2292504 2025-08-25 18:29 b382502e-f84f-4372-9dea-62a998fce0e9zip
-rw-rw---- 1 u0_a509 ext_data_rw  57737216 2025-08-16 19:29 d1d3182d-f597-449e-8adf-97d50b43c2c1zip
-rw-rw---- 1 u0_a509 ext_data_rw   7977759 2025-09-02 10:14 e3f4d1a0-2247-4889-b923-54a32f92df15zip

The newline character is not properly encoded (as would be with ls' -b flag), and since adbsync goes line-by-line, it gets tripped up at the \n.apk and fails.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions