Far-reaching change to how Boolean parameters are handled

This is a far-reaching change to how Boolean parameters are handled. Boolean type tool parameters previously worked simply by the presence of the parameter flag. This was causing problems with some WBT front-ends, particularly QGIS, where the parameters
  were being provided to WBT as --flag=False. In this case, because the flag was present, it was assumed to be True. All tools that have boolean parameters have been updated to handle the case of --flag=False. This is a widespread modification that should fix the unexpected behaviour of many tools in certain front-ends.

Author: jblindsay

.DS_Store

@@ -58,6 +58,13 @@ for more details.
 
 Version 1.0.1 (XX-XX-2019)
 - Fixed a minor bug with the VectorPolygonToRaster tool.
+- Fixed a bug in the DownstreamDistanceToStream tool.
+- Boolean type tool parameters previously worked simply by the presence of the parameter flag.
+  This was causing problems with some WBT front-ends, particularly QGIS, where the parameters
+  were being provided to WBT as --flag=False. In this case, because the flag was present, it 
+  was assumed to be True. All tools that have boolean parameters have been updated to handle
+  the case of --flag=False. This is a widespread modification that should fix the unexpected
+  behaviour of many tools in certain front-ends.
 
 Version 1.0.0 (29-09-2019)
 - Added support for reading and writing the BigTIFF format. This has resulted in numerous changes

readme.txt

@@ -2,7 +2,7 @@
 This tool is part of the WhiteboxTools geospatial analysis library.
 Authors: Dr. John Lindsay
 Created: 24/04/2018
-Last Modified: 12/10/2018
+Last Modified: 18/10/2019
 License: MIT
 */
 
@@ -163,7 +163,9 @@ impl WhiteboxTool for ExportTableToCsv {
                     args[i + 1].to_string()
                 };
             } else if flag_val == "-headers" {
-                headers = true;
+                if !vec[1].to_string().to_lowercase().contains("false") {
+                    headers = true;
+                }
             }
         }
 

src/tools/data_tools/export_table_to_csv.rs

@@ -2,7 +2,7 @@
 This tool is part of the WhiteboxTools geospatial analysis library.
 Authors: Dr. John Lindsay
 Created: 27/09/2018
-Last Modified: 12/10/2018
+Last Modified: 17/10/2019
 License: MIT
 */
 
@@ -172,7 +172,9 @@ impl WhiteboxTool for MultiPartToSinglePart {
                     args[i + 1].to_string()
                 };
             } else if flag_val.contains("-exc") || flag_val.contains("hole") {
-                exclude_holes = true;
+                if !vec[1].to_string().to_lowercase().contains("false") {
+                    exclude_holes = true;
+                }
             }
         }
 

src/tools/data_tools/multipart_to_singlepart.rs

@@ -2,7 +2,7 @@
 This tool is part of the WhiteboxTools geospatial analysis library.
 Authors: Dr. John Lindsay
 Created: 18/04/2018
-Last Modified: 12/10/2018
+Last Modified: 18/10/2019
 License: MIT
 */
 
@@ -229,7 +229,9 @@ impl WhiteboxTool for VectorLinesToRaster {
                     args[i + 1].to_string()
                 };
             } else if flag_val == "-nodata" {
-                background_val = nodata;
+                if !vec[1].to_string().to_lowercase().contains("false") {
+                    background_val = nodata;
+                }
             }
         }
 

src/tools/data_tools/vector_lines_to_raster.rs

@@ -2,7 +2,7 @@
 This tool is part of the WhiteboxTools geospatial analysis library.
 Authors: Dr. John Lindsay
 Created: 19/04/2018
-Last Modified: 12/10/2018
+Last Modified: 18/10/2019
 License: MIT
 */
 
@@ -234,7 +234,9 @@ impl WhiteboxTool for VectorPointsToRaster {
                     args[i + 1].to_string()
                 };
             } else if flag_val == "-nodata" {
-                background_val = nodata;
+                if !vec[1].to_string().to_lowercase().contains("false") {
+                    background_val = nodata;
+                }
             } else if flag_val == "-assign" {
                 assign_op = if keyval {
                     vec[1].to_lowercase()

src/tools/data_tools/vector_points_to_raster.rs

@@ -2,7 +2,7 @@
 This tool is part of the WhiteboxTools geospatial analysis library.
 Authors: Dr. John Lindsay
 Created: 17/04/2018
-Last Modified: 17/07/2019
+Last Modified: 18/10/2019
 License: MIT
 */
 
@@ -207,7 +207,9 @@ impl WhiteboxTool for VectorPolygonsToRaster {
                     args[i + 1].to_string()
                 };
             } else if flag_val == "-nodata" {
-                background_val = nodata;
+                if !vec[1].to_string().to_lowercase().contains("false") {
+                    background_val = nodata;
+                }
             }
         }
 

src/tools/data_tools/vector_polygons_to_raster.rs

@@ -2,7 +2,7 @@
 This tool is part of the WhiteboxTools geospatial analysis library.
 Authors: Dr. John Lindsay
 Created: 09/10/2018
-Last Modified: 13/10/2018
+Last Modified: 18/10/2019
 License: MIT
 */
 
@@ -184,7 +184,9 @@ impl WhiteboxTool for BlockMaximumGridding {
                     args[i + 1].to_string()
                 };
             } else if flag_val == "-use_z" {
-                use_z = true;
+                if !vec[1].to_string().to_lowercase().contains("false") {
+                    use_z = true;
+                }
             } else if flag_val == "-o" || flag_val == "-output" {
                 output_file = if keyval {
                     vec[1].to_string()

src/tools/gis_analysis/block_maximum.rs

@@ -2,7 +2,7 @@
 This tool is part of the WhiteboxTools geospatial analysis library.
 Authors: Dr. John Lindsay
 Created: 09/10/2018
-Last Modified: 13/10/2018
+Last Modified: 18/10/2019
 License: MIT
 */
 
@@ -184,7 +184,9 @@ impl WhiteboxTool for BlockMinimumGridding {
                     args[i + 1].to_string()
                 };
             } else if flag_val == "-use_z" {
-                use_z = true;
+                if !vec[1].to_string().to_lowercase().contains("false") {
+                    use_z = true;
+                }
             } else if flag_val == "-o" || flag_val == "-output" {
                 output_file = if keyval {
                     vec[1].to_string()

src/tools/gis_analysis/block_minimum.rs

@@ -2,7 +2,7 @@
 This tool is part of the WhiteboxTools geospatial analysis library.
 Authors: Dr. John Lindsay
 Created: 22/06/2017
-Last Modified: 13/10/2018
+Last Modified: 18/10/2019
 License: MIT
 */
 
@@ -193,7 +193,9 @@ impl WhiteboxTool for BufferRaster {
             } else if vec[0].to_lowercase() == "-gridcells"
                 || vec[0].to_lowercase() == "--gridcells"
             {
-                grid_cell_units = true;
+                if !vec[1].to_string().to_lowercase().contains("false") {
+                    grid_cell_units = true;
+                }
             }
         }