add emergency relais support, inspired by pr60 #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbruce12000
reviewed
Dec 7, 2024
| self.heat_rate_temps = [] | ||
| self.pid = PID(ki=config.pid_ki, kd=config.pid_kd, kp=config.pid_kp) | ||
| self.catching_up = False | ||
| self.emergency_trigger() |
Owner
There was a problem hiding this comment.
I don't understand why an emergency is triggered here. I think you are using this to shut down power to the kiln relays after each heating cycle.... which seems odd to me.
I would think you would want to shut power to the kiln down when there is a known problem, not 20,000 times during a firing.
Maybe I'm misunderstanding the change?
Owner
There was a problem hiding this comment.
Most everything else looks fine. I would like to see this as optional... so it needs to be tested with and without the setting existing in config.py. It should not error out if the setting does not exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #17 by adding functionality for an in-line mechanical safety relay.
Similar to #60 but updated to current main code and without the led output stuff.
Only tested in lab setup as my oven is not finished yet... Use at your own risk.