Implement step time and slope input #237
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadgetmies
force-pushed
the
implement-step-time-and-slope-input
branch
from
39d4c48 to
499bc25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firing profiles are (AFAIK) defined in terms of step durations and slopes rather than step times. Although the desired slope can be set by dragging the points in the graphs it is not very practical. Additionally, converting the step durations to step times requires some calculation, making it a bit tedious.
I made a quick first draft implementation of introducing editing the step duration and slope in order to get feedback on whether this would be something that might get accepted before committing more time on it. I realise that adding another column of inputs makes the UI more noisy. I initially thought I would add a toggle switch for step duration / step time selection, but eventually did not feel it was necessary.
This commit also hides the first step time input as I do not see how that would ever be anything other than 0.