Deprecation and sanity improvements (#179)

* semonitor: Replace isSet with is_set

The `isSet` is deprecated and an alias for `is_set`. Use that instead to
avoid deprecation warnings.

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>

* se/msg: Be a little bit more carefull with the hardcoded path

The path replacement function tries to remove `/se` from the full path.
However, if the path already contains `/se`, such as for example in
`/solaredge/semonitor/se/msg.py` the path gets completely messed up.

Instead, by using python's `removesuffix`, we get what we wanted.

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>

---------

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Co-authored-by: Eric Buehl <715650+ericbuehl@users.noreply.github.com>

Author: oliv3r

se/msg.py

@@ -16,7 +16,7 @@
 sleepInterval = .1
 
 # Hard coded last0503.msg file. os module used to find full path to calling msg.py file, then removes the se part so it's essentially the root of solaredge (where semonitor.py lives)
-LAST0503FILE = os.path.dirname(os.path.realpath(__file__)).replace('/'+ __name__.split(".")[0], '') + "/last0503.msg"
+LAST0503FILE = os.path.dirname(os.path.realpath(__file__)).removesuffix(__name__.split(".")[0]) + "last0503.msg"
 
 class SECrypto:
     def __init__(self, key, msg0503):

semonitor.py

@@ -108,7 +108,7 @@ def processMsg(msg, args, mode, state, dataFile, recFile, outFile, keyStr, updat
                     (time.localtime().tm_hour - time.gmtime().tm_hour) * 60 * 60)
             elif function == se.commands.PROT_RESP_POLESTAR_MASTER_GRANT_ACK:  # RS485 master release
                 masterEvent.set()
-                se.logutils.setState(state, "masterEvent", masterEvent.isSet())
+                se.logutils.setState(state, "masterEvent", masterEvent.is_set())
             if replyFunction:
                 msg = se.msg.formatMsg(msgSeq, toAddr, fromAddr, replyFunction, replyData)
                 se.msg.sendMsg(dataFile, msg, recFile)
@@ -142,7 +142,7 @@ def masterGrant(state, dataFile, recFile, slaveAddr):
     def masterTimerExpire():
         logger.debug("RS485 master ack timeout")
         masterEvent.set()
-        se.logutils.setState(state, "masterEvent", masterEvent.isSet())
+        se.logutils.setState(state, "masterEvent", masterEvent.is_set())
         se.logutils.setState(state, "masterTimer", False)
 
     # start a timeout to release the bus if the slave doesn't respond
@@ -151,9 +151,9 @@ def masterTimerExpire():
     se.logutils.setState(state, "masterTimer", True)
     # wait for slave to release the bus
     masterEvent.clear()
-    se.logutils.setState(state, "masterEvent", masterEvent.isSet())
+    se.logutils.setState(state, "masterEvent", masterEvent.is_set())
     masterEvent.wait()
-    se.logutils.setState(state, "masterEvent", masterEvent.isSet())
+    se.logutils.setState(state, "masterEvent", masterEvent.is_set())
     # cancel the timeout
     masterTimer.cancel()
     se.logutils.setState(state, "masterTimer", False)