Skip to content

Commit 3e56764

Browse files
authored
Merge pull request #59 from bibonix/upgrade-deps
Bump jcabi parent to 1.44.0 and qulice-maven-plugin to 0.26.0
2 parents 96f55b2 + 02ba068 commit 3e56764

4 files changed

Lines changed: 9 additions & 15 deletions

File tree

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<parent>
3434
<groupId>com.jcabi</groupId>
3535
<artifactId>jcabi</artifactId>
36-
<version>1.40.1</version>
36+
<version>1.44.0</version>
3737
</parent>
3838
<artifactId>jcabi-urn</artifactId>
3939
<version>1.0-SNAPSHOT</version>
@@ -84,7 +84,7 @@
8484
<plugin>
8585
<groupId>com.qulice</groupId>
8686
<artifactId>qulice-maven-plugin</artifactId>
87-
<version>0.25.1</version>
87+
<version>0.26.0</version>
8888
<configuration>
8989
<excludes>
9090
<exclude>duplicatefinder:.*</exclude>

src/main/java/com/jcabi/urn/URN.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ public URN() {
8989
* Public ctor.
9090
* @param text The text of the URN
9191
* @throws URISyntaxException If syntax is not correct
92+
* @checkstyle ConstructorsCodeFreeCheck (10 lines)
9293
*/
9394
public URN(final String text) throws URISyntaxException {
9495
if (text == null) {
@@ -105,6 +106,8 @@ public URN(final String text) throws URISyntaxException {
105106
* Public ctor.
106107
* @param nid The namespace ID
107108
* @param nss The namespace specific string
109+
* @checkstyle ConstructorsCodeFreeCheck (20 lines)
110+
* @checkstyle ConstructorsOrderCheck (20 lines)
108111
*/
109112
public URN(final String nid, final String nss) {
110113
if (nid == null) {
@@ -139,6 +142,7 @@ public static URN create(final String text) {
139142
throw new IllegalArgumentException("URN can't be NULL");
140143
}
141144
try {
145+
// @checkstyle QualifyInnerClassCheck (1 line)
142146
return new URN(text);
143147
} catch (final URISyntaxException ex) {
144148
throw new IllegalArgumentException(ex);
@@ -182,6 +186,7 @@ public int compareTo(final URN urn) {
182186
public static boolean isValid(final String text) {
183187
boolean valid = true;
184188
try {
189+
// @checkstyle QualifyInnerClassCheck (1 line)
185190
new URN(text);
186191
} catch (final URISyntaxException ex) {
187192
valid = false;
@@ -450,5 +455,4 @@ private static boolean allowed(final byte chr) {
450455
|| chr >= 'a' && chr <= 'z'
451456
|| chr == '/' || chr == '-';
452457
}
453-
454458
}

src/mock/java/com/jcabi/urn/URNMocker.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,20 +17,12 @@ public final class URNMocker {
1717
/**
1818
* Namespace ID.
1919
*/
20-
private transient String nid;
20+
private transient String nid = "test";
2121

2222
/**
2323
* Nammespace specific string.
2424
*/
25-
private transient String nss;
26-
27-
/**
28-
* Public ctor.
29-
*/
30-
public URNMocker() {
31-
this.nid = "test";
32-
this.nss = UUID.randomUUID().toString();
33-
}
25+
private transient String nss = UUID.randomUUID().toString();
3426

3527
/**
3628
* With this namespace.
@@ -59,5 +51,4 @@ public URNMocker withNss(final String text) {
5951
public URN mock() {
6052
return new URN(this.nid, this.nss);
6153
}
62-
6354
}

src/test/java/com/jcabi/urn/URNTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,5 +439,4 @@ void checkLexicalEquivalence() {
439439
}
440440
}
441441
}
442-
443442
}

0 commit comments

Comments
 (0)