Remove konk structs from exhaustruct exemptions

Author: jclem

.golangci.yml

@@ -39,11 +39,6 @@ linters-settings:
 
   exhaustruct:
     exclude:
-      - "^github.com/jclem/konk/konk.Command$"
-      - "^github.com/jclem/konk/konk.CommandConfig$"
-      - "^github.com/jclem/konk/konk.RunCommandConfig$"
-      - "^github.com/jclem/konk/konk.ShellCommandConfig$"
-      - "^github.com/jclem/konk/konk.RunConcurrentlyConfig$"
       - "^github.com/spf13/cobra.Command$"
 
   funlen:

cmd/concurrently.go

@@ -40,6 +40,8 @@ var cCommand = cobra.Command{
 		commands, err := konk.RunConcurrently(cmd.Context(), konk.RunConcurrentlyConfig{
 			Commands:        cmdParts,
 			Labels:          labels,
+			Env:             make([]string, 0),
+			OmitEnv:         false,
 			AggregateOutput: aggregateOutput,
 			ContinueOnError: continueOnError,
 			NoColor:         noColor,

cmd/proc.go

@@ -88,9 +88,10 @@ var procCommand = cobra.Command{
 		commands, err := konk.RunConcurrently(cmd.Context(), konk.RunConcurrentlyConfig{
 			Commands:        commandStrings,
 			Labels:          commandLabels,
-			ContinueOnError: continueOnError,
 			Env:             envLines,
 			OmitEnv:         omitEnv,
+			AggregateOutput: false,
+			ContinueOnError: continueOnError,
 			NoColor:         noColor,
 			NoShell:         noShell,
 		})

cmd/serially.go

@@ -56,12 +56,16 @@ var sCommand = cobra.Command{
 					Args:    parts[1:],
 					Label:   labels[i],
 					NoColor: noColor,
+					Env:     make([]string, 0),
+					OmitEnv: false,
 				})
 			} else {
 				c = konk.NewShellCommand(konk.ShellCommandConfig{
 					Command: cmd,
 					Label:   labels[i],
 					NoColor: noColor,
+					Env:     make([]string, 0),
+					OmitEnv: false,
 				})
 			}
 
@@ -74,7 +78,10 @@ var sCommand = cobra.Command{
 			ctx, cancel := context.WithCancel(context.Background())
 			defer cancel()
 
-			if err := c.Run(ctx, cancel, konk.RunCommandConfig{}); err != nil && continueOnError {
+			if err := c.Run(ctx, cancel, konk.RunCommandConfig{
+				AggregateOutput: false,
+				StopOnCancel:    false,
+			}); err != nil && continueOnError {
 				errCmd = err
 			} else if err != nil {
 				return fmt.Errorf("running command: %w", err)

konk/command.go

@@ -41,6 +41,7 @@ func NewShellCommand(conf ShellCommandConfig) *Command {
 
 	return &Command{
 		cmd:    c,
+		out:    strings.Builder{},
 		prefix: prefix,
 	}
 }
@@ -69,6 +70,7 @@ func NewCommand(conf CommandConfig) *Command {
 
 	return &Command{
 		cmd:    cmd,
+		out:    strings.Builder{},
 		prefix: prefix,
 	}
 }