Default task respects dependencies. Fixes #2

Author: Jonathan Como

snake/tasks.py

@@ -153,8 +153,11 @@ def execute(self, _label, **kwargs):
         :param tasks: list of task labels
         :param kwargs: the keyword arguments to pass to each task
         """
-        if not _label and not self.default:
-            raise NoSuchTaskException('default')
+        if not _label:
+            if not self.default:
+                raise NoSuchTaskException('default')
+
+            _label = self.default
 
         for dependency in self._dependencies.resolve(_label):
             self._execute_task(dependency, **kwargs)
@@ -168,9 +171,6 @@ def view_all(self):
         return TaskListFormatter(tasks).tableize(self.name)
 
     def _execute_task(self, _label, **kwargs):
-        if not _label:
-            _label = self.default
-
         try:
             task = self._tasks[_label]
         except KeyError:

tests/tasks_tests.py

@@ -9,6 +9,9 @@ class Flag(object):
     def __init__(self):
         self.value = False
 
+    def __repr__(self):
+        return '<Flag: %s>' % self.value
+
     def __nonzero__(self):
         return self.value
 
@@ -174,6 +177,24 @@ def foo():
         self.registry.default = 'foo'
         self.registry.execute(None)
 
+        self.assertTrue(called)
+
+    def test_default_task_obeys_dependencies(self):
+        called = Flag()
+
+        @self.registry.add_task
+        def foo():
+            called.set()
+
+        @self.registry.add_task(requires=['foo'])
+        def bar():
+            pass
+
+        self.registry.default = 'bar'
+        self.registry.execute(None)
+
+        self.assertTrue(called)
+
     def test_it_raises_assertion_when_default_is_not_string(self):
         with self.assertRaisesRegexp(AssertionError, r"default task must be a string"):
             self.registry.default = lambda: True