AdSizeCons NullReferenceException

[OMendozaG]

Hi,

I'm not sure if this is something expected due to changes in recent SDK versions or a linking error.

When creating a banner (BannerView), you have to assign the AdSizeCons property.

AdSizeCons = AdSizeCons.GetCurrentOrientationAnchoredAdaptiveBannerAdSize

works, but AdSizeCons.Banner, Fluid, FullBanner, LargeBanner, Leaderboard, MediumRectangle, Skyscraper, SmartBannerLandscape, and SmartBannerPortrait, which should be constants that work as banner sizes,

throw a NullReferenceException.

[jcsawyer]

I should be able to take a look at this over the weekend.

[jcsawyer]

@OMendozaG Looking a little deeper into this, it feels a little bigger than I expected.
The problem is the binding for:

FOUNDATION_EXPORT GADAdSize const GADAdSizeBanner NS_SWIFT_NAME(AdSizeBanner);

I'd expect to look something like:

[Static]
[Field("GADAdSizeBanner", "__Internal")]
AdSize Banner { get; }

However the [Field] attribute doesn't work for struct types. I suspect this has been broken in the bindings for a long time, hence why my AdMob Avalonia library just specifies the sizes according to the docs here.

So I see three options:

1. Try to figure out some way to get the binding to work with the way bindings work (I have been playing around with this for a couple hours and couldn't get anywhere)
2. Create a wrapper binding library in Swift/Objective-C with methods to wrap the constants and bind to those
3. Hard code the values in the binding project according to the docs

[OMendozaG]

Hi @jcsawyer,

Thanks for your reply.

#"However the [Field] attribute doesn't work for struct types"

I already assumed that was the issue, but since the class is called AdSizeCons, I thought you might have solved it.

Yes, it's not a major problem because we can always call AdSizeCons.GetCurrentOrientationAnchoredAdaptiveBannerAdSize or something similar and receive the concrete size.

I noticed this because I'm working on the most complete integration possible, partly to contribute tests to this project, which I find wonderful, necessary, and essential.

Right now I'm working on banners, and if I have time in the coming weeks, I’ll look into native ads.

In any case, it's useful to document this for anyone who might need it in the future, so they don’t try to use those consts. The first time I implemented this library and didn’t have time to investigate, I ran into this issue, but I wanted to look into it properly later.

Fortunately, the workaround using "AdSizeCons.GetCurrentOrientationAnchoredAdaptiveBannerAdSize" worked.

As for fixing the project, if solving the struct implementation is too difficult, maybe you could do it “manually”.

The sizes are relatively fixed:

https://developers.google.com/admob/ios/banner/fixed-size

Maybe you could do a GADAdSizeFromCGSize for each of the consts to avoid having a potential null pointer in the lib.

The problem is that you'd have to review each version to check if the sizes remain the same,
and for some values, the docs don’t specify what the exact size is.

For me, if it’s too much work, I don’t think it’s essential to fix it, since there are other ways to call the same thing.

However, I do think this issue should be noted somewhere, and maybe this thread is enough.

Thanks again for all your work :)

[jcsawyer]

I really appreciate the work you're doing - it really helps as I can't test every aspect myself...

I will probably look to hardcode the sizes tomorrow in the bindings as I want to avoid any breaking changes and I don't think they have changed in a long time and I'm almost certain a change in them would be mentioned in change logs, which I have to follow as I update the bindings manually, for the same reason that Objective Sharpie would get these completely wrong and tries to convert them to IntPtrs...

If you're looking at native ads at any point, I know @marius-bughiu has done some work with them here and submitted a fix related to them so hopefully will be painless for you... 🤞

[OMendozaG]

I really appreciate the work you're doing - it really helps as I can't test every aspect myself...

I will probably look to hardcode the sizes tomorrow in the bindings as I want to avoid any breaking changes and I don't think they have changed in a long time and I'm almost certain a change in them would be mentioned in change logs, which I have to follow as I update the bindings manually, for the same reason that Objective Sharpie would get these completely wrong and tries to convert them to IntPtrs...

If you're looking at native ads at any point, I know @marius-bughiu has done some work with them here and submitted a fix related to them so hopefully will be painless for you... 🤞

Well yeah, it’s not ideal, but at least it doesn’t throw a Null on something so basic that it could confuse someone doing a first test while evaluating this library.

Haha, let’s see if I can find a moment for the native ones, I had already seen the post, I’m subscribed to all the repo notifications, thanks!

Honestly, at some point I’d like to be able to help you more, but I’ve never worked with the bindings and I have a MAC with OpenCore legacy that barely runs. If at some point I can dive into it, I’ll try to contribute to things instead of just opening threads, I feel bad haha.

Cheers, my friend!

[jcsawyer]

@OMendozaG You're doing plenty, honestly!
Please give 12.2.2-preview100 a go and let me know how you get on... It's a breaking change, but technically it was broken so I don't think anyone will mind! 👍

[OMendozaG]

Hi @jcsawyer

I've been testing the solution and I'm attaching a report with the results:

AdSizeCons.Banner: Ok
AdSizeCons.Fluid: Not present

AdSizeCons.FullBanner: Error
Domain=com.google.admob Code=0 "Invalid ad width or height: (0, 0)" UserInfo={NSLocalizedDescription=Invalid ad width or height: (0, 0)}
This seems incorrectly assigned; it should be 468x60, but it looks like it's being assigned a 0x0 size.

AdSizeCons.LargeBanner: Ok
AdSizeCons.MediumRectangle: Ok

AdSizeCons.Leaderboard:
Error Domain=com.google.admob Code=0 "Ad size will not fit on screen. a_w=728, a_h=90, s_w=375, s_h=667" UserInfo={NSLocalizedDescription=Ad size will not fit on screen. a_w=728, a_h=90, s_w=375, s_h=667}
It seems correctly integrated, but since it doesn't fit on my device, note the difference with the FullBanner error. Looks like its ok.

AdSize.SmartBanner: Not present but doesn't matter, it's deprecated
AdSizeCons.WideSkyscraper: Not present

I think reviewing AdSizeCons.FullBanner would be enough to validate the solution.

I assume Fluid and WideSkyscraper were removed because their exact values are unknown, as they're not listed in the documentation.

Thank you very much :)

[jcsawyer]

• FullBanner okay this one's a littler strange, it should be the same as the rest 🤔
  • The only banner that should return (0, 0) is the Invalid size...
• Leaderboard I suspect this is okay. I don't know if the underlying SDK does anything fancy to make it fit or anything, probably something I should investigate at some point...
• SmartBanner Another unknown values banner, removed due to deprecation anyway
• Fluid and WideSkyscraper correct, their values are unknown so they could be anything - I suspect they're dynamic (I think most are actually dynamic which is why I want to look at building some alternate solution in the future...

I will take a look at FullBanner and see if I can repro