ci: Updates for latest windows-latest runner image. (#1319)

1. Switch back to windows-latest image.
2. Don't try to remove NSIS 3.x before installing NSIS 2.46, since NSIS 3.x is no longer installed by default.

Author: jcsteh

.github/workflows/build.yml

@@ -22,7 +22,7 @@ jobs:
   build:
     strategy:
       matrix:
-        os: [windows-2022, macos-latest]
+        os: [windows-latest, macos-latest]
     runs-on: ${{ matrix.os }}
     steps:
       - name: set env
@@ -37,7 +37,7 @@ jobs:
             # For example: pr1234-101,23631c6e
             echo version=pr${{ github.event.number }}-$GITHUB_RUN_NUMBER,${GITHUB_SHA:0:8} >> "$GITHUB_ENV"
           fi
-          if [ ${{ matrix.os }} == windows-2022 ]; then
+          if [ ${{ matrix.os }} == windows-latest ]; then
             echo os=windows >> "$GITHUB_ENV"
           else
             echo os=mac >> "$GITHUB_ENV"
@@ -52,16 +52,15 @@ jobs:
       - name: setup
         run: pip install scons
       - name: SCons MSVC Cache
-        if: ${{ matrix.os == 'windows-2022' }}
+        if: ${{ matrix.os == 'windows-latest' }}
         uses: actions/cache@v4
         with:
           path: ~\scons_msvc_cache.json
           key: ${{ env.CACHE_KEY }}
       - name: Windows setup
-        if: ${{ matrix.os == 'windows-2022' }}
+        if: ${{ matrix.os == 'windows-latest' }}
         # Use NSIS 2.46 to reduce AV false positives.
         run: |
-          choco uninstall nsis nsis.install -y
           choco install nsis-unicode -y
       - name: Mac setup
         if: ${{ matrix.os == 'macos-latest' }}
@@ -70,7 +69,7 @@ jobs:
       - name: build
         run: scons "publisher=${{ env.publisher }}" version=${{ env.version }}
       - name: sign Windows
-        if: ${{ github.event_name == 'push' && matrix.os == 'windows-2022' }}
+        if: ${{ github.event_name == 'push' && matrix.os == 'windows-latest' }}
         uses: azure/trusted-signing-action@v0
         with:
           azure-tenant-id: ${{ secrets.AZURE_TENANT_ID }}
@@ -245,7 +244,7 @@ jobs:
           echo "Mac app signed and notarized successfully!"
       # We only need to upload the pot on one OS. We arbitrarily pick Windows.
       - name: pot
-        if: ${{ github.event_name == 'push' && matrix.os == 'windows-2022' }}
+        if: ${{ github.event_name == 'push' && matrix.os == 'windows-latest' }}
         env:
           crowdinAuthToken: ${{ secrets.CROWDIN_AUTH_TOKEN }}
         run: |
@@ -270,7 +269,7 @@ jobs:
           echo ${{ env.os }}Url=${{ fromJSON(steps.uploadBuild.outputs.assets)[0].browser_download_url }} >> "$GITHUB_OUTPUT"
       # We upload pull request builds as normal artifacts.
       - name: upload PR build Win
-        if: ${{ github.event_name == 'pull_request' && matrix.os == 'windows-2022' }}
+        if: ${{ github.event_name == 'pull_request' && matrix.os == 'windows-latest' }}
         uses: actions/upload-artifact@v4
         with:
           name: osara_windows_${{ env.version }}