Skip to content

Fedback for key signature and root key signature (Midi editor) #1168

Open
@aefren

Description

@aefren

Hello . In Reaper , there are shortcuts to change the key signature and root key signature, but there's no feedback from Osara . Currently , the accessible way to change the key and root key signature is by using NVDA 's object navigator or JAWS ' mouse cursor, which disrupts the workflow.

Activity

changed the title [-]Fedback for key signature and root key signature[/-] [+]Fedback for key signature and root key signature (Midi editor)[/+] on Nov 23, 2024
jcsteh

jcsteh commented on Nov 23, 2024

@jcsteh
Owner

Thanks for reporting. It'd be helpful if you could provide details of exactly which actions you're talking about and what you would expect to be announced when you use them. Thanks.

aefren

aefren commented on Nov 26, 2024

@aefren
Author

Here are the actions:

  • Select next key signature root: changes from C to Cb, D, Db, E...
  • Select next key signature: changes to major, melodic minor, harmonic minor, natural minor, Dorian...

Desired behavior: It should announce the new key signature after executing the action.

Current behavior: Nothing is verbalized, although the action does take effect and can be verified using the NVDA object navigator or the mouse cursor in JAWS.

ScottChesworth

ScottChesworth commented on Nov 26, 2024

@ScottChesworth
Collaborator

Pasting the nearest thing I could find in the API but I don't think this is what we need, @jcsteh?

bool MIDI_GetScale(MediaItem_Take* take, int* rootOut, int* scaleOut, char* nameOut, int nameOut_sz)

Get the active scale in the media source, if any. root 0=C, 1=C#, etc. scale &0x1=root, &0x2=minor 2nd, &0x4=major 2nd, &0x8=minor 3rd, &0xF=fourth, etc.

jcsteh

jcsteh commented on Nov 26, 2024

@jcsteh
Owner

Yeah, that should do it, hopefully.

jcsteh

jcsteh commented on Nov 26, 2024

@jcsteh
Owner

I'm hoping the nameOut parameter will provide a nice friendly name like "C major". Otherwise we'll have to invent our own by looking at the rootOut and scaleOut parameters, which is doable but annoying and will definitely require me to brush up on music theory.

RDMurray

RDMurray commented on Jan 15, 2025

@RDMurray
Collaborator

nameOut is just the scale such as "Major",already localized by Reaper.

RDMurray

RDMurray commented on Jan 15, 2025

@RDMurray
Collaborator

While trying to implement this I think I found a bug in Reaper. The action "select next key signature root" changes the note visible in the combobox, but it has no other affect, confirmed by the API and by moving notes around. Selecting the root note directly from the combobox does work however. @ScottChesworth could you report this please?

added a commit that references this issue on Jan 15, 2025
eb824c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Fedback for key signature and root key signature (Midi editor) · Issue #1168 · jcsteh/osara