response to pr comments

jdconrad · jdconrad · commit f82b04fdf52c · 2025-12-12T14:32:28.000-08:00
diff --git a/server/src/main/java/org/elasticsearch/TransportVersion.java b/server/src/main/java/org/elasticsearch/TransportVersion.java
@@ -76,10 +76,12 @@
  */
 public record TransportVersion(String name, int id, TransportVersion nextPatchVersion) implements VersionId<TransportVersion> {
 
+    @Deprecated(forRemoval = true)
     public boolean onOrAfter(TransportVersion version) {
         throw new UnsupportedOperationException("use TransportVersion.supports(...) instead");
     }
 
+    @Deprecated(forRemoval = true)
     public boolean between(TransportVersion lowerInclusive, TransportVersion upperExclusive) {
         throw new UnsupportedOperationException("use TransportVersion.supports(...) && TransportVersion.supports(...) == false instead");
     }
diff --git a/server/src/test/java/org/elasticsearch/TransportVersionTests.java b/server/src/test/java/org/elasticsearch/TransportVersionTests.java
@@ -164,7 +164,7 @@ public void testCURRENTIsLatest() {
 
     public void testPatchVersionsStillAvailable() {
         for (TransportVersion tv : TransportVersion.getAllVersions()) {
-            if (tv.id() >= TransportVersion.fromId(8_84_10_00).id() && (tv.id() % 100) > 90) {
+            if (tv.id() >= 8_84_10_00 && (tv.id() % 100) > 90) {
                 fail(
                     "Transport version "
                         + tv

Original file line number	Diff line number	Diff line change
`@@ -76,10 +76,12 @@`
`76`	`76`	`*/`
`77`	`77`	`public record TransportVersion(String name, int id, TransportVersion nextPatchVersion) implements VersionId<TransportVersion> {`
`78`	`78`
	`79`	`+ @Deprecated(forRemoval = true)`
`79`	`80`	`public boolean onOrAfter(TransportVersion version) {`
`80`	`81`	`throw new UnsupportedOperationException("use TransportVersion.supports(...) instead");`
`81`	`82`	`}`
`82`	`83`
	`84`	`+ @Deprecated(forRemoval = true)`
`83`	`85`	`public boolean between(TransportVersion lowerInclusive, TransportVersion upperExclusive) {`
`84`	`86`	`throw new UnsupportedOperationException("use TransportVersion.supports(...) && TransportVersion.supports(...) == false instead");`
`85`	`87`	`}`