same execution regardless of value?

try:
    if options.func == do_register_client:
        conn = admin_conn
    else:
        conn = admin_conn
    result = options.func(options, conn)

What's the purpose of this? the conn = admin_conn executes regardless (both if and else execute it).

[jdennis]

To be honest I don't recall, in part because the cli part of the utility code in keycloak_cli.py is hardly ever used. It was mostly there to support development efforts so I could exercise various Keycloak REST API's in isolation. One of the problems with Keycloak and hence this code is there are too many ways to do the same thing and in the early days of Keycloak there was a lot of back and forth on how best to do things with different trade-offs, including different authentication requirements. I suspect what happend here is some experiment was done and admin auth was required and I just forced the code to perform that, but honestly I don't remember.

The tool in it's current form is too complicated, it has too many options and needs to be simplified. At some point we plan on adding OIDC support as well and at that point we'll have to make architectural changes that hopefully will eliminate some of the redundancy.

[jdennis]

Just another quick thought, if you're reading this code to learn how to call the Keycloak REST API you should note the Keycloak team developed an admin cli tool after this work was done. It's Java based. I don't know the state of the tool but from looking at this issue in the customer portal (https://access.redhat.com/solutions/3205781) it does not appear the team intends to support it, of course these things change. I believe the source for the tool is in their git repo. I have not looked at this code yet, mostly because it was done well after we did keycloak-httpd-client-install, it's not installable, and it requires Java on the client. But on the other hand it was written by the same developers that authored the REST API in the first place so their approach might be better because they have inside knowledge about the quirks of the REST API (there are many).