Skip to content

Commit 4b1d512

Browse files
author
Jack Dermody
committed
clean up
1 parent 2275bdc commit 4b1d512

File tree

61 files changed

+359
-318
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+359
-318
lines changed

‎Benchmarks/DataTableBenchmarks.cs‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,9 @@
11
using BenchmarkDotNet.Attributes;
2-
using System;
3-
using System.Collections.Generic;
4-
using System.Linq;
52
using System.Reflection;
6-
using System.Text;
7-
using System.Threading.Tasks;
83
using BrightData;
94
using BrightData.Parquet;
105
using Parquet;
116
using Parquet.Data;
12-
using Parquet.Schema;
137

148
namespace Benchmarks
159
{
@@ -22,8 +16,8 @@ public class DataTableBenchmarks
2216
public void GlobalSetup()
2317
{
2418
_dataContext = new BrightDataContext();
25-
_housePricesParquet = Assembly.GetExecutingAssembly().GetManifestResourceStream("Benchmarks.Data.house-price.parquet") ?? throw new InvalidOperationException($"Not able to find embedded resource");
26-
_housePricesDataTable = Assembly.GetExecutingAssembly().GetManifestResourceStream("Benchmarks.Data.house-price.dat") ?? throw new InvalidOperationException($"Not able to find embedded resource");
19+
_housePricesParquet = Assembly.GetExecutingAssembly().GetManifestResourceStream("Benchmarks.Data.house-price.parquet") ?? throw new InvalidOperationException("Not able to find embedded resource");
20+
_housePricesDataTable = Assembly.GetExecutingAssembly().GetManifestResourceStream("Benchmarks.Data.house-price.dat") ?? throw new InvalidOperationException("Not able to find embedded resource");
2721
}
2822

2923
public async Task SaveDataTable(string outputPath)

‎Benchmarks/Program.cs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
using System.Reflection;
2-
using System.Runtime.InteropServices;
1+
using System.Runtime.InteropServices;
32
using BenchmarkDotNet.Running;
43

54
namespace Benchmarks

‎BrightData.Cuda/CudaLinearAlgebraProvider.cs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
using BrightData.LinearAlgebra;
1010
using BrightData.LinearAlgebra.Segments;
1111
using CommunityToolkit.HighPerformance.Buffers;
12-
using static System.Runtime.InteropServices.JavaScript.JSType;
1312

1413
namespace BrightData.Cuda
1514
{

‎BrightData.Cuda/CudaToolkit/Types/CuStream.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public static CuStream StreamPerThread
3636
return s;
3737
}
3838
}
39-
public ulong Id
39+
public readonly ulong Id
4040
{
4141
get
4242
{

‎BrightData.Cuda/Helper/DeviceMemoryBlockBase.cs‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
using System;
2-
using System.Collections.Generic;
3-
using System.Diagnostics;
42
using System.Threading;
53
using BrightData.Cuda.CudaToolkit;
64
using BrightData.Cuda.CudaToolkit.Types;
7-
using BrightData.Helper;
85
using Math = System.Math;
96

107
namespace BrightData.Cuda.Helper

‎BrightData.DataFrame/ExtensionMethods.cs‎

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using Microsoft.Data.Analysis;
2-
using System.Linq;
32

43
namespace BrightData.DataFrame
54
{
@@ -14,16 +13,16 @@ public static Microsoft.Data.Analysis.DataFrame ToDataFrame(this IDataTable data
1413

1514
return (DataFrameColumn)(dataType switch {
1615
BrightDataType.Boolean => new BooleanDataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<bool>((uint)i).Enumerate()),
17-
BrightDataType.Date => new DateTimeDataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<DateTime>((uint)i).Enumerate()),
18-
BrightDataType.Double => new DoubleDataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<double>((uint)i).Enumerate()),
16+
BrightDataType.Date => new DateTimeDataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<DateTime>((uint)i).Enumerate()),
17+
BrightDataType.Double => new DoubleDataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<double>((uint)i).Enumerate()),
1918
BrightDataType.Decimal => new DecimalDataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<decimal>((uint)i).Enumerate()),
20-
BrightDataType.Float => new SingleDataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<float>((uint)i).Enumerate()),
21-
BrightDataType.Int => new Int32DataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<int>((uint)i).Enumerate()),
22-
BrightDataType.Long => new Int64DataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<long>((uint)i).Enumerate()),
23-
BrightDataType.SByte => new SByteDataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<sbyte>((uint)i).Enumerate()),
24-
BrightDataType.Short => new Int16DataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<short>((uint)i).Enumerate()),
25-
BrightDataType.String => new StringDataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<string>((uint)i).Enumerate()),
26-
_ => throw new NotSupportedException($"{dataType} cannot be converted to data frame column")
19+
BrightDataType.Float => new SingleDataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<float>((uint)i).Enumerate()),
20+
BrightDataType.Int => new Int32DataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<int>((uint)i).Enumerate()),
21+
BrightDataType.Long => new Int64DataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<long>((uint)i).Enumerate()),
22+
BrightDataType.SByte => new SByteDataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<sbyte>((uint)i).Enumerate()),
23+
BrightDataType.Short => new Int16DataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<short>((uint)i).Enumerate()),
24+
BrightDataType.String => new StringDataFrameColumn(metaData.GetName(defaultName), dataTable.GetColumn<string>((uint)i).Enumerate()),
25+
_ => throw new NotSupportedException($"{dataType} cannot be converted to data frame column")
2726
});
2827
})
2928
);

‎BrightData.UnitTests/CsvParserTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public async Task Parse_WhenValidCsvString_ReturnsExpectedResult()
2222
result.Should().NotBeNull();
2323
result.Should().HaveCount(2);
2424

25-
var firstColumn = result![0];
25+
var firstColumn = result[0];
2626
firstColumn.MetaData.GetName().Should().Be("Name");
2727
var firstColumnData = await firstColumn.ToArray();
2828
firstColumnData.Should().NotBeNull();
@@ -57,7 +57,7 @@ public async Task ParseAsync_WhenValidCsvStream_ReturnsExpectedResult()
5757
result.Should().NotBeNull();
5858
result.Should().HaveCount(2);
5959

60-
var firstColumn = result![0];
60+
var firstColumn = result[0];
6161
var firstColumnData = await firstColumn.ToArray();
6262
firstColumnData.Should().NotBeNull();
6363
firstColumnData.Should().HaveCount(3);

‎BrightData.UnitTests/DataEncoderTests.Complex.cs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
using BrightData.UnitTests.Fixtures;
44
using Xunit;
55
using FluentAssertions;
6-
using FluentAssertions.Equivalency;
76
using BrightData.Types;
87

98
namespace BrightData.UnitTests

‎BrightData.UnitTests/DirectedGraphTests.cs‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
11
using FluentAssertions;
2-
using System;
3-
using System.Collections.Generic;
4-
using System.Linq;
5-
using System.Text;
6-
using System.Threading.Tasks;
72
using BrightData.Types.Graph;
83
using Xunit;
94

‎BrightData.UnitTests/FixedSizeArrayTests.cs‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
1-
using System;
2-
using System.Collections.Generic;
3-
using System.Linq;
4-
using System.Text;
5-
using System.Threading.Tasks;
6-
using BrightData.Types;
7-
using BrightData.Types.Graph;
1+
using BrightData.Types;
82
using FluentAssertions;
93
using Xunit;
104

0 commit comments

Comments
 (0)