Revise code according to suggestions @bthirion in issue nilearn#173

Author: Gilles86

nistats/first_level_model.py

@@ -18,6 +18,7 @@
 import numpy as np
 import pandas as pd
 from nibabel import Nifti1Image
+from nibabel.onetime import setattr_on_read
 
 from sklearn.base import (BaseEstimator,
                           clone,
@@ -613,15 +614,15 @@ def get_voxelwise_model_attribute_(self, attribute, timeseries=True):
         else:
             return output
 
-    @property
+    @setattr_on_read
     def residuals(self):
         return self.get_voxelwise_model_attribute_('resid')
 
-    @property
+    @setattr_on_read
     def predicted(self):
         return self.get_voxelwise_model_attribute_('predicted')
 
-    @property
+    @setattr_on_read
     def rsq(self):
         return self.get_voxelwise_model_attribute_('rsq', timeseries=False)
 

nistats/regression.py

@@ -278,14 +278,14 @@ def __init__(self, theta, Y, model, wY, wresid, cov=None, dispersion=1.,
         self.wresid = wresid
         self.wdesign = model.wdesign
 
-    @property
+    @setattr_on_read
     def resid(self):
         """
         Residuals from the fit.
         """
         return self.Y - self.predicted
 
-    @property
+    @setattr_on_read
     def norm_resid(self):
         """
         Residuals, normalized to have unit length.
@@ -305,7 +305,7 @@ def norm_resid(self):
         """
         return self.resid * positive_reciprocal(np.sqrt(self.dispersion))
 
-    @property
+    @setattr_on_read
     def predicted(self):
         """ Return linear predictor values from a design matrix.
         """
@@ -363,14 +363,12 @@ def logL(self, Y):
         """
         raise ValueError('minimize_memory should be set to False to make residuals or predictions.')
 
-    @setattr_on_read
     def resid(self):
         """
         Residuals from the fit.
         """
         raise ValueError('minimize_memory should be set to False to make residuals or predictions.')
 
-    @setattr_on_read
     def norm_resid(self):
         raise ValueError("SimpleRegressionResults does not store residuals."  
                         "If needed, use the RegressionResults class.")