Skip to content

Commit 9d230dc

Browse files
committed
polish tutorial and README
1 parent bf464fa commit 9d230dc

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ The Python modules are written in **Python 3.x**, which is the minimum requireme
3333

3434
## Quick Start
3535

36-
v0.8.7a1 as a hot fix over v0.8.6 includes several important changes in user interface. We highly recommend that you go through the [tutorial](https://github.com/jdlph/Path4GMNS/tree/dev/tests/tutorial.ipynb) written in Jupyter notebook with step-by-step demonstration using the latest release, no matter you are one of the existing users or new to Path4GMNS.
36+
v0.8.7a1 as a hot fix over v0.8.6 includes several important changes in user interface. We highly recommend that you go through [this tutorial](https://github.com/jdlph/Path4GMNS/tree/dev/tests/tutorial.ipynb) written in Jupyter notebook with step-by-step demonstration using the latest version, no matter you are one of the existing users or new to Path4GMNS.
3737

3838
## User Manual
3939

@@ -560,9 +560,8 @@ DTALite uses arrays rather than STL containers to store columns. These arrays ar
560560
23. Fix crucial bug in column generation module which will lead to wrong results if a zone has multiple nodes (v0.8.6)
561561
24. Fix crucial bug in setting up the capacity of each VDFPeriod instance if the input is missing from link.csv (v0.8.6)
562562
25. Add backwards compatibility on deprecated default agent type of p or passenger (v0.8.7a1)
563-
26. Fix potential issue that bin_index might not start from zero when all zones have the same number of nodes in _synthesize_bin_index() (v0.8.7a1)
564-
27. Fix potential zero division issue in _synthesize_bin_index() when min_ and max_ are the same (v0.8.7a1)
565-
28. Elaborate the legacy way of loading demand and zone information in tutorial (v0.8.7a1)
563+
26. Fix potential issue that bin_index might not start from zero along with potential zero division issue when all zones have the same number of nodes in _synthesize_bin_index() (v0.8.7a1)
564+
27. Elaborate the legacy way of loading demand and zone information in tutorial (v0.8.7a1)
566565

567566
Detailed update information can be found in [Releases](https://github.com/jdlph/Path4GMNS/releases).
568567

tests/tutorial.ipynb

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@
5757
"source": [
5858
"download_sample_data_sets() will download five sample data sets including ASU, Braess Paradox, Chicago Sketch, Lima Network, Sioux Falls, and Two Corridors. Each of them contains the following files.\n",
5959
"\n",
60-
"1. link.csv\n",
61-
"2. node.csv\n",
60+
"1. node.csv\n",
61+
"2. link.csv\n",
6262
"3. demand.csv\n",
6363
"4. settings.yml (for multimodal analyses)\n",
6464
"5. settings.csv (for DTALite)"
@@ -293,9 +293,7 @@
293293
"\n",
294294
"Accessiblity defines where you can go given a time budget and a transportation mode (e.g., auto). You can find the number of accessible zones from each zone (zone_accessibility.csv) along with the free flow travel time for each OD pair (od_accessibility.csv).\n",
295295
"\n",
296-
"The default mode is 'auto' and the default time budget is 240 minutes. We will come back to multimodal evaluation in a later section.\n",
297-
"\n",
298-
"Zone information is necessary for accessibility evaluation."
296+
"The default mode is 'auto' and the default time budget is 240 minutes. We will come back to multimodal evaluation in a later section. Zone information is necessary for accessibility evaluation."
299297
]
300298
},
301299
{
@@ -336,6 +334,7 @@
336334
"metadata": {},
337335
"outputs": [],
338336
"source": [
337+
"# no need to load demand file for equity evaluation\n",
339338
"network = pg.read_network()\n",
340339
"pg.read_zones(network)\n",
341340
"\n",
@@ -468,6 +467,7 @@
468467
"metadata": {},
469468
"outputs": [],
470469
"source": [
470+
"# no need to load demand file for accessibility evaluation\n",
471471
"network = pg.read_network()\n",
472472
"pg.read_zones(network)\n",
473473
"\n",
@@ -479,7 +479,7 @@
479479
"id": "premium-italian",
480480
"metadata": {},
481481
"source": [
482-
"### 4.5 Perform Multimodal Evaluation\n",
482+
"### 4.5 Perform Multimodal Equity Evaluation\n",
483483
"\n",
484484
"By removing \"single_mode=True\" from the arugment list in evaluate_equity(), multimodal evaluation will be triggered for all modes defined in settings.yml"
485485
]
@@ -491,6 +491,7 @@
491491
"metadata": {},
492492
"outputs": [],
493493
"source": [
494+
"# no need to load demand file for equity evaluation\n",
494495
"network = pg.read_network()\n",
495496
"pg.read_zones(network)\n",
496497
"\n",
@@ -599,10 +600,12 @@
599600
"\n",
600601
"During the early development of Path4GMNS, demand.csv is presumed to be given and zone information is provided along node.csv. The latter is the current design of GMNS and is endorsed in [OSM2GMNS](https://github.com/jiawlu/OSM2GMNS). This assumption leads to the following legacy way (as the original design of Path4GMNS) to load demand and zone information while the new way demonstrated was in **Section 3.2**. \n",
601602
"\n",
603+
"\n",
602604
"```python\n",
603605
"network = pg.read_network(load_demand=True)\n",
604606
"```\n",
605607
"\n",
608+
"\n",
606609
"The demand file is specified in settings.yml as demand.csv. You can change it to any demand file in your PWD. This design actually allows us to load multiple demand files simultaneously corresponding to different period and agent_type. We will elaborate it in a future release.\n",
607610
"\n",
608611
"```yaml\n",
@@ -749,7 +752,7 @@
749752
"outputs": [],
750753
"source": [
751754
"# zone info must be present in node.csv\n",
752-
"# no need to load demand file for accessibility evaluation\n",
755+
"# no need to load demand file for equity evaluation\n",
753756
"network = pg.read_network()\n",
754757
"\n",
755758
"pg.evaluate_equity(network)"

0 commit comments

Comments
 (0)