Skip to content

Commit 34dd8a7

Browse files
Jamesclaude
andcommitted
docs(fork): 1.3 provenance exit check PASS; 2.4 review-size counts corrected to measured
The 1.3 grep found one nonconforming phrase — the plan's own closing line said 'and credit'; corrected to the Part-1.2 framing. The draft's review-size claim (~873 lines) was stale and understated the branch: measured ~1,432 source insertions across 5 files plus ~2,202 test lines (git diff --shortstat upstream-mirror...fix/dom-oom-virtualization); odysseus-dev#4661's vendored trim is 142 lines. Matrix row and prose updated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 1687e53 commit 34dd8a7

2 files changed

Lines changed: 13 additions & 3 deletions

File tree

docs/fork/plans/dom-oom-virtualization-upstream-plan.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ message window and scroll fixes"): authored 2026-06-11 20:47 UTC. #4661 opened
3535
1.3 **Exit check:** before filing, grep the draft and all fork docs for `4661`; every
3636
reference must match 1.2 verbatim in substance. Nothing may claim adaptation from #4661 and
3737
nothing may argue about influence.
38+
**Run 2026-07-18: PASS** (draft, decision record, pr-status, eviction draft all conform;
39+
the one nonconforming phrase found — this plan's own closing line said "and credit" — was
40+
corrected to the 1.2 framing). The streaming-throttle branch's genuine adaptation credits
41+
are a different branch and are out of scope. Re-run once more at file time.
3842

3943
1.4 **Exit check:** a reviewer comparing the two diffs finds every claim verifiable and
4044
nothing argued about provenance beyond the 1.2 facts.
@@ -88,6 +92,12 @@ and verified.
8892
2.4 **Honest tradeoff, stated up front.** Ours is ~873 lines vs #4661's ~145. Cite the
8993
maintainability cost honestly; do not bury it. The pitch is "more complete and measured,"
9094
not "theirs is bad."
95+
**Verified 2026-07-18 — the old counts were stale and understated our size.** Measured:
96+
#4661's trim is 142 lines (the vendored file); the branch's source diff is ~1,432
97+
insertions across 5 files, plus ~2,202 test lines
98+
(`git diff --shortstat upstream-mirror...fix/dom-oom-virtualization`). Draft matrix row
99+
and prose corrected to the measured numbers. Re-measure after the Part-5 rebuild (the
100+
fold will grow the diff further).
91101

92102
2.5 **Exit check:** every row of the matrix has a number and a verified citation, and the
93103
tradeoff is stated.
@@ -283,4 +293,4 @@ first):
283293
claims, no fork-internal leaks).
284294

285295
Until then the branch stays unfiled. #4661 being open is not a blocker; it is the reference
286-
we measure against and credit.
296+
we measure against, acknowledged as parallel work per Part 1.2.

docs/fork/upstream/pr-drafts/fix-dom-oom-virtualization.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ commit `27f35e1c` as `tests/bench/vendor/trimChatHistory_4661.js`, provenance-gu
110110
| Reaching old history | scroll (all live) | 97 "show older" clicks, full restore, scroll position lost | scroll-up pages in place, window stays bounded |
111111
| Append layout cost, 25-msg stream (ms) | 101.3 | 4.7 | 3.2 |
112112
| Scroll smoothness (mean frame ms) | 16.7 | 16.7 | 16.7 |
113-
| Review size (lines) || ~145 | ~873 |
113+
| Review size (source lines changed) || ~142 | ~1,430 (5 files; plus ~2,200 test lines) |
114114

115115
The two rows that decide it: #4661's cap genuinely bounds the steady state, but the moment
116116
a user reads old history the bound is gone — the DOM and USS return to the unpatched
@@ -134,7 +134,7 @@ relationship is precise, and stated honestly:
134134
releases hljs-defer observer references via `hljsDeferForgetNode`. Those uncleaned
135135
observers and renderers were confirmed leak sources in the fork's OOM investigation
136136
(`docs/fork/memory-explosion-research.md`).
137-
- **The windowing is more complete.** #4661 is a focused top-only trim (~145 lines): a
137+
- **The windowing is more complete.** #4661 is a focused top-only trim (~142 lines): a
138138
150-node cap, removal from the top, and a "load older" bar backed by server pagination.
139139
This adds bidirectional windowing so a user can scroll back up and reload evicted
140140
messages in place.

0 commit comments

Comments
 (0)