|
| 1 | +"""Tests for the AC-coupled `external_solar_mode` battery setting. |
| 2 | +
|
| 3 | +When enabled, the SOLAR_STORAGE strategic intent must translate to |
| 4 | +`grid_charge=True` so the battery can AC-charge from surplus solar that |
| 5 | +returns via the meter (the battery inverter has no DC solar input). |
| 6 | +All other intents must keep their default mapping. |
| 7 | +""" |
| 8 | + |
| 9 | +import pytest |
| 10 | + |
| 11 | +from core.bess.settings import BatterySettings |
| 12 | +from core.bess.solax_controller import SolaxController |
| 13 | + |
| 14 | + |
| 15 | +def _settings(*, external_solar_mode: bool) -> BatterySettings: |
| 16 | + return BatterySettings( |
| 17 | + total_capacity=10.0, |
| 18 | + max_charge_power_kw=5.0, |
| 19 | + max_discharge_power_kw=5.0, |
| 20 | + min_soc=15.0, |
| 21 | + max_soc=95.0, |
| 22 | + external_solar_mode=external_solar_mode, |
| 23 | + ) |
| 24 | + |
| 25 | + |
| 26 | +class TestExternalSolarModeOverride: |
| 27 | + def test_default_is_disabled(self) -> None: |
| 28 | + assert BatterySettings(total_capacity=10.0).external_solar_mode is False |
| 29 | + |
| 30 | + def test_solar_storage_grid_charge_false_when_disabled(self) -> None: |
| 31 | + ctrl = SolaxController(battery_settings=_settings(external_solar_mode=False)) |
| 32 | + grid_charge, discharge_rate = ctrl._map_intent_to_rates("SOLAR_STORAGE", 0.0) |
| 33 | + assert grid_charge is False |
| 34 | + assert discharge_rate == 0 |
| 35 | + |
| 36 | + def test_solar_storage_grid_charge_true_when_enabled(self) -> None: |
| 37 | + ctrl = SolaxController(battery_settings=_settings(external_solar_mode=True)) |
| 38 | + grid_charge, discharge_rate = ctrl._map_intent_to_rates("SOLAR_STORAGE", 0.0) |
| 39 | + assert grid_charge is True |
| 40 | + assert discharge_rate == 0 |
| 41 | + |
| 42 | + @pytest.mark.parametrize( |
| 43 | + "intent,expected_grid_charge", |
| 44 | + [ |
| 45 | + ("GRID_CHARGING", True), |
| 46 | + ("LOAD_SUPPORT", False), |
| 47 | + ("BATTERY_EXPORT", False), |
| 48 | + ("IDLE", False), |
| 49 | + ], |
| 50 | + ) |
| 51 | + def test_other_intents_unaffected_when_enabled( |
| 52 | + self, intent: str, expected_grid_charge: bool |
| 53 | + ) -> None: |
| 54 | + ctrl = SolaxController(battery_settings=_settings(external_solar_mode=True)) |
| 55 | + grid_charge, _ = ctrl._map_intent_to_rates(intent, 0.0) |
| 56 | + assert grid_charge is expected_grid_charge |
| 57 | + |
| 58 | + def test_detailed_period_groups_apply_override(self) -> None: |
| 59 | + ctrl = SolaxController(battery_settings=_settings(external_solar_mode=True)) |
| 60 | + ctrl.strategic_intents = ["SOLAR_STORAGE"] * 96 |
| 61 | + groups = ctrl.get_detailed_period_groups() |
| 62 | + assert groups, "expected at least one period group" |
| 63 | + for group in groups: |
| 64 | + assert group["grid_charge"] is True |
| 65 | + assert group["intent"] == "SOLAR_STORAGE" |
| 66 | + |
| 67 | + def test_detailed_period_groups_no_override_when_disabled(self) -> None: |
| 68 | + ctrl = SolaxController(battery_settings=_settings(external_solar_mode=False)) |
| 69 | + ctrl.strategic_intents = ["SOLAR_STORAGE"] * 96 |
| 70 | + groups = ctrl.get_detailed_period_groups() |
| 71 | + for group in groups: |
| 72 | + assert group["grid_charge"] is False |
| 73 | + |
| 74 | + def test_get_period_settings_applies_override_without_schedule(self) -> None: |
| 75 | + ctrl = SolaxController(battery_settings=_settings(external_solar_mode=True)) |
| 76 | + ctrl.strategic_intents = ["SOLAR_STORAGE"] * 96 |
| 77 | + ctrl.current_schedule = None |
| 78 | + settings = ctrl.get_period_settings(period=10) |
| 79 | + assert settings["grid_charge"] is True |
| 80 | + assert settings["strategic_intent"] == "SOLAR_STORAGE" |
| 81 | + |
| 82 | + |
| 83 | +class TestExternalSolarModeBattModeOverride: |
| 84 | + """external_solar_mode should also flip SOLAR_STORAGE's mode to battery_first. |
| 85 | +
|
| 86 | + On AC-coupled setups, Load First mode does not initiate battery charging |
| 87 | + even with grid_charge enabled — the EMS waits for a trigger that never |
| 88 | + comes. Battery First mode makes the inverter actively charge from the |
| 89 | + AC side. |
| 90 | + """ |
| 91 | + |
| 92 | + def test_solar_storage_mode_is_load_first_when_disabled(self) -> None: |
| 93 | + ctrl = SolaxController(battery_settings=_settings(external_solar_mode=False)) |
| 94 | + ctrl.strategic_intents = ["SOLAR_STORAGE"] * 96 |
| 95 | + settings = ctrl.get_period_settings(period=10) |
| 96 | + assert settings["batt_mode"] == "load_first" |
| 97 | + |
| 98 | + def test_solar_storage_mode_is_battery_first_when_enabled(self) -> None: |
| 99 | + ctrl = SolaxController(battery_settings=_settings(external_solar_mode=True)) |
| 100 | + ctrl.strategic_intents = ["SOLAR_STORAGE"] * 96 |
| 101 | + settings = ctrl.get_period_settings(period=10) |
| 102 | + assert settings["batt_mode"] == "battery_first" |
| 103 | + |
| 104 | + @pytest.mark.parametrize( |
| 105 | + "intent,expected_mode", |
| 106 | + [ |
| 107 | + ("GRID_CHARGING", "battery_first"), |
| 108 | + ("LOAD_SUPPORT", "load_first"), |
| 109 | + ("BATTERY_EXPORT", "grid_first"), |
| 110 | + ("IDLE", "load_first"), |
| 111 | + ], |
| 112 | + ) |
| 113 | + def test_other_intents_unaffected_when_enabled( |
| 114 | + self, intent: str, expected_mode: str |
| 115 | + ) -> None: |
| 116 | + ctrl = SolaxController(battery_settings=_settings(external_solar_mode=True)) |
| 117 | + ctrl.strategic_intents = [intent] * 96 |
| 118 | + settings = ctrl.get_period_settings(period=10) |
| 119 | + assert settings["batt_mode"] == expected_mode |
| 120 | + |
| 121 | + def test_detailed_period_groups_apply_mode_override(self) -> None: |
| 122 | + ctrl = SolaxController(battery_settings=_settings(external_solar_mode=True)) |
| 123 | + ctrl.strategic_intents = ["SOLAR_STORAGE"] * 96 |
| 124 | + groups = ctrl.get_detailed_period_groups() |
| 125 | + assert groups, "expected at least one period group" |
| 126 | + for group in groups: |
| 127 | + assert group["mode"] == "battery_first" |
| 128 | + assert group["grid_charge"] is True |
0 commit comments