Skip to content

Commit 11b905e

Browse files
author
merge-queue-bot
committed
Merge PR #689: audit(2026-06-24): flag test-debt and rename dedup tax
2 parents 09f22d3 + 457ab73 commit 11b905e

8 files changed

Lines changed: 706 additions & 1 deletion

PLAN.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,4 +224,8 @@ footer: |
224224
| 2606211910 || | [arch-fix: add trivial-accessor exemption comments in workspace.go](plan/2606211910_arch-fix-workspace-exemptions.md) |
225225
| 2606231013 || sonnet | [Add dedicated unit tests for inline_scan.go helpers](plan/2606231013_arch-fix-inline-scan-helper-tests.md) |
226226
| 2606231014 || sonnet | [Add dedicated unit tests for samefileanchor helper functions](plan/2606231014_arch-fix-samefileanchor-helper-tests.md) |
227+
| 2606240211 || sonnet | [Add dedicated unit tests for locate.go helpers](plan/2606240211_arch-fix-locate-helper-tests.md) |
228+
| 2606240212 | 🔲 | sonnet | [Add dedicated unit tests for lsp/rename.go helpers](plan/2606240212_arch-fix-lsp-rename-helper-tests.md) |
229+
| 2606240213 | 🔲 | sonnet | [Add dedicated unit tests for export.go helpers and two small rename helpers](plan/2606240213_arch-fix-export-helper-tests.md) |
230+
| 2606240214 | 🔲 | sonnet | [Remove duplicated helpers between lsp/rename.go and rename/rename.go](plan/2606240214_arch-fix-rename-dedup.md) |
227231
<?/catalog?>

docs/development/architecture-audit.md

Lines changed: 53 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ summary: >-
66
solid-architecture skill (audit mode)
77
appends here; blockers are also filed as
88
plans.
9-
audit-from: 1599c9f17336b36d4d06d10677b2510bfe33665b
9+
audit-from: 09f22d3a59ea9cc07911df1db2d462da7d5fccb1
1010
---
1111
# Architecture audit log
1212

@@ -220,3 +220,55 @@ layering impact.
220220

221221
[2606231013]: ../../plan/2606231013_arch-fix-inline-scan-helper-tests.md
222222
[2606231014]: ../../plan/2606231014_arch-fix-samefileanchor-helper-tests.md
223+
224+
## Audit 2026-06-24 (range: 1599c9f..09f22d3)
225+
226+
Perf series (struct-alignment, Sprintf→strconv,
227+
`[]byte` FindSubmatch, Builder). Plans 2606231013
228+
and 2606231014 closed. Benchmark docs and security
229+
SARIF retired. No TypeScript changes. 273 Go
230+
sources outside fixtures.
231+
232+
No blockers. No rule-to-rule imports. No DIP
233+
violations. No file crossed 1 000 lines.
234+
235+
### tax (2026-06-24)
236+
237+
- `internal/index/locate.go` — 12 unexported
238+
helpers lack dedicated unit tests. Tests doc
239+
§"every function by name" —
240+
[plan/2606240211][2606240211].
241+
242+
- `internal/lsp/rename.go` — 15 unexported
243+
helpers lack dedicated unit tests. Tests doc
244+
§"every function by name" —
245+
[plan/2606240212][2606240212].
246+
247+
- `internal/export/export.go` — 11 unexported
248+
helpers lack dedicated unit tests. Tests doc
249+
§"every function by name" —
250+
[plan/2606240213][2606240213].
251+
252+
- `internal/lsp/rename.go` and
253+
`internal/rename/rename.go``normalizedLabel`
254+
and `refDefBracketBytes` are duplicated. Both
255+
have identical bodies. Hub §"Anti-patterns" —
256+
[plan/2606240214][2606240214].
257+
258+
- `internal/rules/concisenessscoring/rule.go`
259+
and `internal/rename/rename.go`
260+
`countClassifierTokens` and
261+
`contentBlockLines` lack dedicated unit tests.
262+
Batched into [plan/2606240213][2606240213].
263+
264+
### nice-to-have (2026-06-24)
265+
266+
- `internal/index/locate.go`
267+
`isGlobPattern` is a trivial one-liner with no
268+
branch. Add "// no test by design" so the audit
269+
can distinguish it from forgotten test debt.
270+
271+
[2606240211]: ../../plan/2606240211_arch-fix-locate-helper-tests.md
272+
[2606240212]: ../../plan/2606240212_arch-fix-lsp-rename-helper-tests.md
273+
[2606240213]: ../../plan/2606240213_arch-fix-export-helper-tests.md
274+
[2606240214]: ../../plan/2606240214_arch-fix-rename-dedup.md

internal/index/locate.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,7 @@ var piArgRE = regexp.MustCompile(`^\s*([A-Za-z_][A-Za-z0-9_-]*)\s*:\s*(.*?)\s*$`
487487
var piListItemRE = regexp.MustCompile(`^\s*-\s+(.*?)\s*$`)
488488

489489
// isGlobPattern reports whether p contains doublestar glob metacharacters.
490+
// no test by design: trivial one-liner with no branch.
490491
func isGlobPattern(p string) bool { return strings.ContainsAny(p, "*?[{") }
491492

492493
// headingOnLine returns the heading whose first source line equals

0 commit comments

Comments
 (0)