Skip to content

Commit 246823d

Browse files
committed
fix: address Copilot review on PR #157
- Rename TestNewGitignoreMatcher_MalformedGitignore to TestNewGitignoreMatcher_UnreadableGitignore to accurately describe the failure mode (unreadable file, not malformed syntax) - Add runtime.GOOS == "windows" skip alongside the existing root skip to avoid platform-specific flakes from POSIX chmod semantics https://claude.ai/code/session_018673HUFUK6ceA9YyxH3HKg
1 parent fd7fbff commit 246823d

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

internal/lint/lint_coverage_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package lint
33
import (
44
"os"
55
"path/filepath"
6+
"runtime"
67
"testing"
78

89
"github.com/stretchr/testify/assert"
@@ -224,7 +225,10 @@ func TestNewGitignoreMatcher_NestedGitignore(t *testing.T) {
224225
assert.True(t, len(m.rules) >= 2)
225226
}
226227

227-
func TestNewGitignoreMatcher_MalformedGitignore(t *testing.T) {
228+
func TestNewGitignoreMatcher_UnreadableGitignore(t *testing.T) {
229+
if runtime.GOOS == "windows" {
230+
t.Skip("permission test not reliable on Windows")
231+
}
228232
if os.Getuid() == 0 {
229233
t.Skip("permission test not reliable as root")
230234
}

0 commit comments

Comments
 (0)