Skip to content

Commit 26df529

Browse files
author
merge-queue-bot
committed
Merge PR #506: Rename pr-fixup skill to gh-pr-fixup; replace merge-queue Copilot gate with /code-review
2 parents 07615cf + 41efa8d commit 26df529

9 files changed

Lines changed: 24 additions & 38 deletions

File tree

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
name: pr-fixup
2+
name: gh-pr-fixup
33
description: >-
44
Push changes, monitor CI, and address review comments
55
until the PR is clean. Run after creating or updating
@@ -135,12 +135,12 @@ gh api --method POST \
135135

136136
### 5. Schedule recurring polling
137137

138-
Use the `/loop` skill to re-invoke `/pr-fixup` every
138+
Use the `/loop` skill to re-invoke `/gh-pr-fixup` every
139139
minute. This avoids blocking bash loops and long-running
140140
`--watch` commands:
141141

142142
```text
143-
/loop 1m /pr-fixup
143+
/loop 1m /gh-pr-fixup
144144
```
145145

146146
On each invocation, check CI and review threads. If

.claude/skills/merge-queue/SKILL.md

Lines changed: 11 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ workflow only runs for same-repo PRs targeting
6767
### 2. Verify readiness
6868

6969
Confirm CI is green, no review threads are
70-
unresolved, and the latest commit has a Copilot
71-
review before enqueuing.
70+
unresolved, and a high-effort code review leaves
71+
nothing to fix before enqueuing.
7272

7373
Check CI:
7474

@@ -108,34 +108,20 @@ are more than 100 threads and you must paginate
108108
before trusting the count.
109109

110110
Stop if the count is greater than zero. Run
111-
`/pr-fixup` first to address the remaining
111+
`/gh-pr-fixup` first to address the remaining
112112
threads.
113113

114-
Check that Copilot reviewed the latest commit:
114+
Run a final high-effort code review and auto-apply
115+
its fixes:
115116

116-
```bash
117-
gh api --paginate "repos/$OWNER/$REPO/pulls/$PR/reviews" \
118-
-q '[.[] | select(.user.login ==
119-
"copilot-pull-request-reviewer[bot]")]
120-
| last | .commit_id'
121-
```
122-
123-
Compare the returned commit SHA with the PR head:
124-
125-
```bash
126-
gh pr view "$PR" --json commits \
127-
-q '.commits[-1].oid'
117+
```text
118+
/code-review xhigh --fix
128119
```
129120

130-
If the two SHAs do not match, Copilot has not
131-
reviewed the latest push. Request a review and
132-
wait before enqueuing:
133-
134-
```bash
135-
gh api --method POST \
136-
"repos/$OWNER/$REPO/pulls/$PR/requested_reviewers" \
137-
-f 'reviewers[]=copilot-pull-request-reviewer[bot]'
138-
```
121+
If the review changes any files, the branch is not
122+
ready — run `/gh-pr-fixup` to commit, push, and
123+
re-run CI before enqueuing. If it makes no changes,
124+
the review is clean; proceed.
139125

140126
### 3. Add the `queue` label
141127

.claude/skills/pick-plan/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ since this is what shows in the Agent's status line).
428428

429429
When the Agent returns, relay its summary to the user
430430
in two or three sentences plus the PR URL from step 8.
431-
The user can then run `/pr-fixup` to babysit CI and
431+
The user can then run `/gh-pr-fixup` to babysit CI and
432432
review comments.
433433

434434
## Gotchas

.github/AGENTS-PR-FIXUP.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,12 +128,12 @@ gh api --method POST \
128128

129129
### 5. Schedule recurring polling
130130

131-
Use the `/loop` skill to re-invoke `/pr-fixup` every
131+
Use the `/loop` skill to re-invoke `/gh-pr-fixup` every
132132
minute. This avoids blocking bash loops and long-running
133133
`--watch` commands:
134134

135135
```text
136-
/loop 1m /pr-fixup
136+
/loop 1m /gh-pr-fixup
137137
```
138138

139139
On each invocation, check CI and review threads. If

.github/copilot-instructions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ row: "- [{summary}](../{filename})"
147147

148148
### PR Workflow
149149

150-
Use the `/pr-fixup`, `/gh-resolve-threads`, and `/merge-queue`
150+
Use the `/gh-pr-fixup`, `/gh-resolve-threads`, and `/merge-queue`
151151
skills for PR work — they cover rebases, CI monitoring, thread
152152
resolution, and merge enqueuing. After every push, request a
153153
Copilot re-review (the skills do this automatically).

.github/copilot-pr-fixup.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,12 @@ gh api --method POST \
121121

122122
### 5. Schedule recurring polling
123123

124-
Use the `/loop` skill to re-invoke `/pr-fixup` every
124+
Use the `/loop` skill to re-invoke `/gh-pr-fixup` every
125125
minute. This avoids blocking bash loops and long-running
126126
`--watch` commands:
127127

128128
```text
129-
/loop 1m /pr-fixup
129+
/loop 1m /gh-pr-fixup
130130
```
131131

132132
On each invocation, check CI and review threads. If

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ row: "- [{summary}]({filename})"
153153

154154
## PR Workflow
155155

156-
Use the `/pr-fixup`, `/gh-resolve-threads`, and `/merge-queue`
156+
Use the `/gh-pr-fixup`, `/gh-resolve-threads`, and `/merge-queue`
157157
skills for PR work — they cover rebases, CI monitoring, thread
158158
resolution, and merge enqueuing. After every push, request a
159159
Copilot re-review (the skills do this automatically).

CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ row: "- [{summary}]({filename})"
139139

140140
## PR Workflow
141141

142-
Use the `/pr-fixup`, `/gh-resolve-threads`, and `/merge-queue`
142+
Use the `/gh-pr-fixup`, `/gh-resolve-threads`, and `/merge-queue`
143143
skills for PR work — they cover rebases, CI monitoring, thread
144144
resolution, and merge enqueuing. After every push, request a
145145
Copilot re-review (the skills do this automatically).

docs/development/pr-fixup-workflow.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,12 +120,12 @@ gh api --method POST \
120120

121121
### 5. Schedule recurring polling
122122

123-
Use the `/loop` skill to re-invoke `/pr-fixup` every
123+
Use the `/loop` skill to re-invoke `/gh-pr-fixup` every
124124
minute. This avoids blocking bash loops and long-running
125125
`--watch` commands:
126126

127127
```text
128-
/loop 1m /pr-fixup
128+
/loop 1m /gh-pr-fixup
129129
```
130130

131131
On each invocation, check CI and review threads. If

0 commit comments

Comments
 (0)