test+refactor: fix dead conditional assert and unify Sprintf in conciseness rule

Two fixes from code-review round 3:

- rule_test.go: TestCheck_MessageNoConcatenationWhenExamplesPresent guarded
  the assert.Contains(msg, "e.g.,") behind `if strings.Contains(msg, "reduce
  verbose cues")`, making it a no-op in the exact regression it was meant to
  catch (message drops cue text → outer if is false → inner assert never runs).
  verboseParagraph() always produces cues, so assert both strings
  unconditionally. Remove the now-unused "strings" import.

- rule.go: Replace the if/else with two identical fmt.Sprintf call sites (same
  three arguments, same format prefix) with a single call that takes a
  conditional cuesSuffix string. The base format string now lives in one place
  so it can't diverge between the cue and no-cue paths.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015QYub2iGP6CeeEFSfjV3Wv

Author: claude

internal/rules/concisenessscoring/rule.go

@@ -98,18 +98,14 @@ func (r *Rule) Check(f *lint.File) []lint.Diagnostic {
 
 		line := astutil.ParagraphLine(para, f)
 		examples := formatExamples(result.Cues)
-		var message string
-		if examples == "" {
-			message = fmt.Sprintf(
-				"conciseness score too low (%.2f < %.2f); target >= %.2f",
-				result.Conciseness, r.MinScore, r.MinScore,
-			)
-		} else {
-			message = fmt.Sprintf(
-				"conciseness score too low (%.2f < %.2f); target >= %.2f; reduce verbose cues (e.g., %s)",
-				result.Conciseness, r.MinScore, r.MinScore, examples,
-			)
+		var cuesSuffix string
+		if examples != "" {
+			cuesSuffix = "; reduce verbose cues (e.g., " + examples + ")"
 		}
+		message := fmt.Sprintf(
+			"conciseness score too low (%.2f < %.2f); target >= %.2f%s",
+			result.Conciseness, r.MinScore, r.MinScore, cuesSuffix,
+		)
 
 		diags = append(diags, lint.Diagnostic{
 			File:     f.Path,

internal/rules/concisenessscoring/rule_test.go

@@ -2,7 +2,6 @@ package concisenessscoring
 
 import (
 	"errors"
-	"strings"
 	"sync"
 	"testing"
 
@@ -314,14 +313,12 @@ func TestCheck_MessageNoConcatenationWhenExamplesPresent(t *testing.T) {
 		t.Skip("model threshold did not trigger on fixture")
 	}
 	msg := diags[0].Message
-	// The message must contain both the score summary and the cue guidance
-	// in a single string (not two separately allocated pieces).
+	// The message must contain both the score summary and the cue guidance.
 	assert.Contains(t, msg, "conciseness score too low")
 	assert.Contains(t, msg, "target >=")
-	// If verbose cues were detected, the formatted examples must also be present.
-	if strings.Contains(msg, "reduce verbose cues") {
-		assert.Contains(t, msg, "e.g.,", "message with cues must include formatted examples")
-	}
+	// verboseParagraph always triggers cue detection; both must be present.
+	assert.Contains(t, msg, "reduce verbose cues")
+	assert.Contains(t, msg, "e.g.,", "message with cues must include formatted examples")
 }
 
 func TestCheck_NoCuesMessage(t *testing.T) {