Skip to content

Commit 4a16047

Browse files
author
merge-queue-bot
committed
Merge PR #677: arch(engine): split runner.go SRP violation into sibling files
2 parents 74f15cc + bf85ed8 commit 4a16047

11 files changed

Lines changed: 778 additions & 361 deletions

PLAN.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,4 +218,8 @@ footer: |
218218
| 2606192027 || sonnet | [Security hardening batch — 2026-06-19 full-repo audit (low/info)](plan/2606192027_security-hardening-batch-2026-06-19-full-repo.md) |
219219
| 2606202100 | 🔳 | opus | [Parity perf: make InlineBlocks a light inline scan, not a goldmark re-parse](plan/2606202100_parity-light-inline-scan.md) |
220220
| 2606210840 || sonnet | [Same-file anchor-resolution rule for true gomarklint parity](plan/2606210840_same-file-anchor-resolution-rule.md) |
221+
| 2606211907 || | [arch-fix: split internal/engine/runner.go](plan/2606211907_arch-fix-runner-srp-split.md) |
222+
| 2606211908 | 🔲 | | [arch-fix: split internal/lint/layer0.go](plan/2606211908_arch-fix-layer0-split.md) |
223+
| 2606211909 | 🔲 | | [arch-fix: split internal/lsp/server.go](plan/2606211909_arch-fix-lsp-server-split.md) |
224+
| 2606211910 | 🔲 | | [arch-fix: add trivial-accessor exemption comments in workspace.go](plan/2606211910_arch-fix-workspace-exemptions.md) |
221225
<?/catalog?>

docs/development/architecture-audit.md

Lines changed: 62 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ summary: >-
66
solid-architecture skill (audit mode)
77
appends here; blockers are also filed as
88
plans.
9-
audit-from: 7793b974e35ec7260ae986e9e0dd48cf5df30574
9+
audit-from: e701b94b5640dfb4f5d07d1fc38d49e0dba23e75
1010
---
1111
# Architecture audit log
1212

@@ -132,3 +132,64 @@ Tax: [build→rules DIP](../../plan/2606141910_arch-fix-build-rules-dip.md),
132132
Lazy-parse series (plans 2606141901–2606141904).
133133
Tax: [new-pkg-docs](../../plan/2606162213_arch-fix-new-pkg-docs.md),
134134
[helper-tests](../../plan/2606162214_arch-fix-missing-helper-tests.md).
135+
136+
## Audit 2026-06-21 (range: 7793b97..e701b94)
137+
138+
Parity + Layer-0 parse-skip series; symlink
139+
containment; engine panic recovery; VS Code
140+
`kinds` and `rule-doc` commands; security
141+
hardening batch. 270 Go/TS sources outside
142+
fixtures.
143+
144+
No blockers. New rule / convention packages
145+
follow the OCP barrel pattern correctly; no
146+
rule-to-rule imports added; no DIP violations
147+
in the new `internal/rules/listscan` helper
148+
(it follows the established `astutil` /
149+
`fencepos` pattern).
150+
151+
### tax (2026-06-21)
152+
153+
- `internal/engine/runner.go` (1 290 lines) —
154+
SRP violation. Seven concerns in one file:
155+
file dispatch, Layer-0 skip gate,
156+
config-resolution cache, source-mode lint
157+
path, front-matter parsing, config-target
158+
rules, and logging. Go arch doc
159+
§"Common violations to flag" names engine
160+
as a dumping-ground risk. Fixed this cycle:
161+
split into `runner_layer0.go`,
162+
`runner_cache.go`, `runner_log.go`
163+
[plan/2606211907][2606211907].
164+
165+
- `internal/lint/layer0.go` (1 203 lines) —
166+
the full Layer-0 block scanner in one file:
167+
types, scanner state machine, HTML-block
168+
detection (types 1–7), fence handling, ATX
169+
heading, indented code, paragraph. Maintenance
170+
risk at this size. Fix: split along
171+
block-type sub-parsers —
172+
[plan/2606211908][2606211908].
173+
174+
- `internal/lsp/server.go` (1 007 lines) —
175+
plan 203 was green but the file has crept
176+
back over 1 000 lines with the new `kinds`
177+
and `rule-doc` capability wiring. Checklist
178+
names it explicitly. Fix: apply the same
179+
dispatch-group split plan 203 described —
180+
[plan/2606211909][2606211909].
181+
182+
### nice-to-have (2026-06-21)
183+
184+
- `pkg/mdsmith/workspace.go` trivial methods
185+
(`memFile.Close`, `memDir.Close`,
186+
`memDirEntry.Name`, `memDirEntry.IsDir`,
187+
`memFileInfo.Name`, `memFileInfo.Size`) lack
188+
the one-line "no test by design" exemption
189+
comment the audit policy requires. Tests doc
190+
§"Exemptions" — [plan/2606211910][2606211910].
191+
192+
[2606211907]: ../../plan/2606211907_arch-fix-runner-srp-split.md
193+
[2606211908]: ../../plan/2606211908_arch-fix-layer0-split.md
194+
[2606211909]: ../../plan/2606211909_arch-fix-lsp-server-split.md
195+
[2606211910]: ../../plan/2606211910_arch-fix-workspace-exemptions.md

0 commit comments

Comments
 (0)