Cover release-trigger guard 100%

Agent-Logs-Url: https://github.com/jeduden/mdsmith/sessions/e63ff353-75c0-40a1-a466-0603d1b4868a

Co-authored-by: jeduden <1117699+jeduden@users.noreply.github.com>

Author: Copilot

cmd/mdsmith-release/triggerguard_test.go

@@ -7,6 +7,7 @@ import (
 	"path/filepath"
 	"testing"
 
+	"github.com/jeduden/mdsmith/internal/release"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
@@ -32,3 +33,44 @@ func TestRunCheckReleaseTriggerWritesGitHubOutput(t *testing.T) {
 	require.NoError(t, err)
 	assert.Equal(t, "should_run=true\ncreate_release_is_draft=true\n", string(body))
 }
+
+// TestRunCheckReleaseTriggerReportsCheckError covers the
+// reportError branch when CheckReleaseTrigger itself fails
+// (here: create-event tag without a token).
+func TestRunCheckReleaseTriggerReportsCheckError(t *testing.T) {
+	t.Setenv("EVENT_NAME", "create")
+	t.Setenv("CREATE_REF_TYPE", "tag")
+	t.Setenv("RELEASE_TAG", "v1.2.3")
+	t.Setenv("GITHUB_REPOSITORY", "jeduden/mdsmith")
+	t.Setenv("GITHUB_TOKEN", "")
+	t.Setenv("GITHUB_OUTPUT", "")
+
+	assert.Equal(t, 1, run([]string{"check-release-trigger"}))
+}
+
+// TestRunCheckReleaseTriggerReportsWriteError covers the
+// reportError branch when writeReleaseTriggerGuardOutput fails
+// (here: GITHUB_OUTPUT points at a directory).
+func TestRunCheckReleaseTriggerReportsWriteError(t *testing.T) {
+	dir := t.TempDir()
+	t.Setenv("EVENT_NAME", "push")
+	t.Setenv("GITHUB_OUTPUT", dir)
+
+	assert.Equal(t, 1, run([]string{"check-release-trigger"}))
+}
+
+// TestWriteReleaseTriggerGuardOutputStdout covers the path=="" branch
+// (no GITHUB_OUTPUT set) which prints to stdout instead of opening
+// a file.
+func TestWriteReleaseTriggerGuardOutputStdout(t *testing.T) {
+	err := writeReleaseTriggerGuardOutput("", release.TriggerGuardResult{ShouldRun: true})
+	require.NoError(t, err)
+}
+
+// TestWriteReleaseTriggerGuardOutputOpenError covers the
+// os.OpenFile error branch.
+func TestWriteReleaseTriggerGuardOutputOpenError(t *testing.T) {
+	dir := t.TempDir()
+	err := writeReleaseTriggerGuardOutput(dir, release.TriggerGuardResult{})
+	require.Error(t, err)
+}

internal/release/triggerguard.go

@@ -94,12 +94,10 @@ func CheckReleaseTrigger(opts TriggerGuardOptions) (TriggerGuardResult, error) {
 				CreateReleaseIsDraft: draft,
 			}, nil
 		}
-		if attempt == attempts {
-			return TriggerGuardResult{}, nil
+		if attempt < attempts {
+			sleep(delay)
 		}
-		sleep(delay)
 	}
-
 	return TriggerGuardResult{}, nil
 }
 

internal/release/triggerguard_test.go

@@ -1,9 +1,12 @@
 package release
 
 import (
+	"errors"
 	"fmt"
+	"io"
 	"net/http"
 	"net/http/httptest"
+	"strings"
 	"sync"
 	"testing"
 	"time"
@@ -191,3 +194,118 @@ type roundTripFunc func(*http.Request) (*http.Response, error)
 func (f roundTripFunc) RoundTrip(req *http.Request) (*http.Response, error) {
 	return f(req)
 }
+
+// TestCheckReleaseTriggerUsesDefaultAPIBase verifies that an
+// empty APIBaseURL falls back to api.github.com (line covered:
+// the apiBase == "" branch).
+func TestCheckReleaseTriggerUsesDefaultAPIBase(t *testing.T) {
+	var gotURL string
+	client := &http.Client{Transport: roundTripFunc(func(r *http.Request) (*http.Response, error) {
+		gotURL = r.URL.String()
+		return &http.Response{
+			StatusCode: http.StatusOK,
+			Body:       io.NopCloser(strings.NewReader(`{"draft":true}`)),
+			Header:     make(http.Header),
+		}, nil
+	})}
+	res, err := CheckReleaseTrigger(TriggerGuardOptions{
+		EventName:  "create",
+		Repository: "jeduden/mdsmith",
+		RefType:    "tag",
+		RefName:    "v1.2.3",
+		Token:      "t",
+		Client:     client,
+	})
+	require.NoError(t, err)
+	assert.True(t, res.ShouldRun)
+	assert.Equal(t, "https://api.github.com/repos/jeduden/mdsmith/releases/tags/v1.2.3", gotURL)
+}
+
+// TestCheckReleaseTriggerNewRequestError trips http.NewRequest by
+// passing an APIBaseURL containing a control character so the URL
+// parser rejects it.
+func TestCheckReleaseTriggerNewRequestError(t *testing.T) {
+	_, err := CheckReleaseTrigger(TriggerGuardOptions{
+		EventName:  "create",
+		Repository: "jeduden/mdsmith",
+		RefType:    "tag",
+		RefName:    "v1.2.3",
+		Token:      "t",
+		APIBaseURL: "http://example.com\x7f",
+	})
+	require.Error(t, err)
+}
+
+// TestCheckReleaseTriggerClientDoError propagates a transport
+// error from client.Do.
+func TestCheckReleaseTriggerClientDoError(t *testing.T) {
+	sentinel := errors.New("transport boom")
+	client := &http.Client{Transport: roundTripFunc(func(*http.Request) (*http.Response, error) {
+		return nil, sentinel
+	})}
+	_, err := CheckReleaseTrigger(TriggerGuardOptions{
+		EventName:  "create",
+		Repository: "jeduden/mdsmith",
+		RefType:    "tag",
+		RefName:    "v1.2.3",
+		Token:      "t",
+		APIBaseURL: "https://api.example.com",
+		Client:     client,
+	})
+	require.ErrorIs(t, err, sentinel)
+}
+
+type errReadCloser struct{ err error }
+
+func (e errReadCloser) Read([]byte) (int, error) { return 0, e.err }
+func (e errReadCloser) Close() error             { return nil }
+
+// TestCheckReleaseTriggerReadBodyError covers the io.ReadAll
+// error branch of lookupReleaseDraft.
+func TestCheckReleaseTriggerReadBodyError(t *testing.T) {
+	sentinel := errors.New("read boom")
+	client := &http.Client{Transport: roundTripFunc(func(*http.Request) (*http.Response, error) {
+		return &http.Response{
+			StatusCode: http.StatusOK,
+			Body:       errReadCloser{err: sentinel},
+			Header:     make(http.Header),
+		}, nil
+	})}
+	_, err := CheckReleaseTrigger(TriggerGuardOptions{
+		EventName:  "create",
+		Repository: "jeduden/mdsmith",
+		RefType:    "tag",
+		RefName:    "v1.2.3",
+		Token:      "t",
+		APIBaseURL: "https://api.example.com",
+		Client:     client,
+	})
+	require.ErrorIs(t, err, sentinel)
+}
+
+// TestCheckReleaseTriggerInvalidJSONErrors covers the
+// json.Unmarshal error branch of lookupReleaseDraft.
+func TestCheckReleaseTriggerInvalidJSONErrors(t *testing.T) {
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
+		_, _ = fmt.Fprint(w, `{not json`)
+	}))
+	t.Cleanup(srv.Close)
+
+	_, err := CheckReleaseTrigger(TriggerGuardOptions{
+		EventName:  "create",
+		Repository: "jeduden/mdsmith",
+		RefType:    "tag",
+		RefName:    "v1.2.3",
+		Token:      "t",
+		APIBaseURL: srv.URL,
+	})
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), "parse ")
+}
+
+// TestReleaseLookupErrorEmptyBody pins the empty-body formatting
+// branch of releaseLookupError.Error.
+func TestReleaseLookupErrorEmptyBody(t *testing.T) {
+	e := &releaseLookupError{URL: "https://x/y", StatusCode: 503}
+	assert.Equal(t, "lookup https://x/y: unexpected GitHub API status 503", e.Error())
+}