Skip to content

Commit bb9d9e8

Browse files
Copilotjeduden
andauthored
Polish release trigger docs readability
Agent-Logs-Url: https://github.com/jeduden/mdsmith/sessions/3f65518b-df4e-4054-9129-17a8e12b30a5 Co-authored-by: jeduden <1117699+jeduden@users.noreply.github.com>
1 parent cc71711 commit bb9d9e8

1 file changed

Lines changed: 11 additions & 12 deletions

File tree

docs/development/release.md

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -46,22 +46,21 @@ git push origin v0.13.0
4646
```
4747

4848
A `v*` tag push still triggers the published-release
49-
path, and `release.yml` also listens to the repo's
50-
`create` event so a draft release created in the
51-
GitHub UI can start the pipeline when that UI call
52-
creates a new `v*` tag. GitHub does not fire
53-
`release` workflows for draft creation, so the
54-
workflow job guards check `ref_type=tag` and
55-
`ref_name starts with v` on `create` runs instead.
49+
path. `release.yml` also listens to the repo's
50+
`create` event. That covers the GitHub UI path where
51+
a draft release creates a new `v*` tag. GitHub does
52+
not fire `release` workflows for draft creation. On
53+
`create` runs, the workflow job guards check
54+
`ref_type=tag` and `ref_name starts with v`.
5655

5756
`release.yml` still omits `workflow_dispatch`,
5857
`pull_request_target`, `workflow_run`, and
5958
`release`. Those triggers could mint OIDC tokens or
60-
reach the PATs from a non-tag context, and the
61-
`release` event would still miss draft creation.
62-
When the run started from `create`, the final
63-
GitHub Release upload keeps the release in draft
64-
state; a normal tag push keeps the current
59+
reach the PATs from a non-tag context. The `release`
60+
event would also still miss draft creation. When
61+
the run started from `create`, the final GitHub
62+
Release upload keeps the release in draft state. A
63+
normal tag push keeps the current
6564
published-release behavior.
6665

6766
`concurrency: { group: release, cancel-in-progress: false }`

0 commit comments

Comments
 (0)