rename MDS036 to max-section-length

claude · claude · commit e80290695ac9 · 2026-04-19T20:42:27.000Z
Align with max-file-length naming. "Size" was ambiguous (bytes?
tokens?); "length" mirrors the file-level analog and makes it clear
the limit counts lines. Renames:

- package sectionsizelimits -&gt; maxsectionlength
- rule name section-size-limits -&gt; max-section-length
- fixture dir MDS036-section-size-limits -&gt; MDS036-max-section-length
diff --git a/cmd/mdsmith/main.go b/cmd/mdsmith/main.go
@@ -40,6 +40,7 @@ import (
 	_ "github.com/jeduden/mdsmith/internal/rules/linelength"
 	_ "github.com/jeduden/mdsmith/internal/rules/listindent"
 	_ "github.com/jeduden/mdsmith/internal/rules/maxfilelength"
+	_ "github.com/jeduden/mdsmith/internal/rules/maxsectionlength"
 	_ "github.com/jeduden/mdsmith/internal/rules/nobareurls"
 	_ "github.com/jeduden/mdsmith/internal/rules/noduplicateheadings"
 	_ "github.com/jeduden/mdsmith/internal/rules/noemphasisasheading"
@@ -51,7 +52,6 @@ import (
 	_ "github.com/jeduden/mdsmith/internal/rules/paragraphreadability"
 	_ "github.com/jeduden/mdsmith/internal/rules/paragraphstructure"
 	_ "github.com/jeduden/mdsmith/internal/rules/requiredstructure"
-	_ "github.com/jeduden/mdsmith/internal/rules/sectionsizelimits"
 	_ "github.com/jeduden/mdsmith/internal/rules/singletrailingnewline"
 	_ "github.com/jeduden/mdsmith/internal/rules/tableformat"
 	_ "github.com/jeduden/mdsmith/internal/rules/tablereadability"
diff --git a/internal/config/config_test.go b/internal/config/config_test.go
@@ -28,6 +28,7 @@ import (
 	_ "github.com/jeduden/mdsmith/internal/rules/linelength"
 	_ "github.com/jeduden/mdsmith/internal/rules/listindent"
 	_ "github.com/jeduden/mdsmith/internal/rules/maxfilelength"
+	_ "github.com/jeduden/mdsmith/internal/rules/maxsectionlength"
 	_ "github.com/jeduden/mdsmith/internal/rules/nobareurls"
 	_ "github.com/jeduden/mdsmith/internal/rules/noduplicateheadings"
 	_ "github.com/jeduden/mdsmith/internal/rules/noemphasisasheading"
@@ -38,7 +39,6 @@ import (
 	_ "github.com/jeduden/mdsmith/internal/rules/paragraphreadability"
 	_ "github.com/jeduden/mdsmith/internal/rules/paragraphstructure"
 	_ "github.com/jeduden/mdsmith/internal/rules/requiredstructure"
-	_ "github.com/jeduden/mdsmith/internal/rules/sectionsizelimits"
 	_ "github.com/jeduden/mdsmith/internal/rules/singletrailingnewline"
 	_ "github.com/jeduden/mdsmith/internal/rules/tableformat"
 	_ "github.com/jeduden/mdsmith/internal/rules/tablereadability"
diff --git a/internal/engine/categories_test.go b/internal/engine/categories_test.go
@@ -26,14 +26,14 @@ import (
 	_ "github.com/jeduden/mdsmith/internal/rules/headingstyle"
 	_ "github.com/jeduden/mdsmith/internal/rules/linelength"
 	_ "github.com/jeduden/mdsmith/internal/rules/listindent"
+	_ "github.com/jeduden/mdsmith/internal/rules/maxsectionlength"
 	_ "github.com/jeduden/mdsmith/internal/rules/nobareurls"
 	_ "github.com/jeduden/mdsmith/internal/rules/noduplicateheadings"
 	_ "github.com/jeduden/mdsmith/internal/rules/noemphasisasheading"
 	_ "github.com/jeduden/mdsmith/internal/rules/nohardtabs"
 	_ "github.com/jeduden/mdsmith/internal/rules/nomultipleblanks"
 	_ "github.com/jeduden/mdsmith/internal/rules/notrailingpunctuation"
 	_ "github.com/jeduden/mdsmith/internal/rules/notrailingspaces"
-	_ "github.com/jeduden/mdsmith/internal/rules/sectionsizelimits"
 	_ "github.com/jeduden/mdsmith/internal/rules/singletrailingnewline"
 	_ "github.com/jeduden/mdsmith/internal/rules/tokenbudget"
 )
diff --git a/internal/integration/rules_test.go b/internal/integration/rules_test.go
@@ -32,6 +32,7 @@ import (
 	_ "github.com/jeduden/mdsmith/internal/rules/linelength"
 	_ "github.com/jeduden/mdsmith/internal/rules/listindent"
 	_ "github.com/jeduden/mdsmith/internal/rules/maxfilelength"
+	_ "github.com/jeduden/mdsmith/internal/rules/maxsectionlength"
 	_ "github.com/jeduden/mdsmith/internal/rules/nobareurls"
 	_ "github.com/jeduden/mdsmith/internal/rules/noduplicateheadings"
 	_ "github.com/jeduden/mdsmith/internal/rules/noemphasisasheading"
@@ -43,7 +44,6 @@ import (
 	_ "github.com/jeduden/mdsmith/internal/rules/paragraphreadability"
 	_ "github.com/jeduden/mdsmith/internal/rules/paragraphstructure"
 	_ "github.com/jeduden/mdsmith/internal/rules/requiredstructure"
-	_ "github.com/jeduden/mdsmith/internal/rules/sectionsizelimits"
 	_ "github.com/jeduden/mdsmith/internal/rules/singletrailingnewline"
 	_ "github.com/jeduden/mdsmith/internal/rules/tableformat"
 	_ "github.com/jeduden/mdsmith/internal/rules/tablereadability"
diff --git a/internal/rules/MDS036-max-section-length/README.md b/internal/rules/MDS036-max-section-length/README.md
@@ -1,15 +1,15 @@
 ---
 id: MDS036
-name: section-size-limits
+name: max-section-length
 status: ready
 description: Section length must not exceed per-level or per-heading limits.
 ---
-# MDS036: section-size-limits
+# MDS036: max-section-length
 
 Section length must not exceed per-level or per-heading limits.
 
 - **ID**: MDS036
-- **Name**: `section-size-limits`
+- **Name**: `max-section-length`
 - **Status**: ready
 - **Default**: disabled
 - **Fixable**: no
@@ -40,15 +40,15 @@ Enable with a default limit:
 
 ```yaml
 rules:
-  section-size-limits:
+  max-section-length:
     max: 100
 ```
 
 Per-level and per-heading overrides:
 
 ```yaml
 rules:
-  section-size-limits:
+  max-section-length:
     max: 100
     per-level:
       1: 200
@@ -62,7 +62,7 @@ Disable:
 
 ```yaml
 rules:
-  section-size-limits: false
+  max-section-length: false
 ```
 
 ## Examples
diff --git a/internal/rules/MDS036-max-section-length/bad/default.md b/internal/rules/MDS036-max-section-length/bad/default.md
diff --git a/internal/rules/MDS036-max-section-length/bad/per-level.md b/internal/rules/MDS036-max-section-length/bad/per-level.md
diff --git a/internal/rules/MDS036-max-section-length/good/default.md b/internal/rules/MDS036-max-section-length/good/default.md
diff --git a/internal/rules/MDS036-max-section-length/good/per-level.md b/internal/rules/MDS036-max-section-length/good/per-level.md
diff --git a/internal/rules/index.md b/internal/rules/index.md
@@ -52,5 +52,5 @@ row: "| [{id}]({filename}) | `{name}` | {status} | {description} |"
 | [MDS031](MDS031-unclosed-code-block/README.md)                | `unclosed-code-block`                | ready     | Fenced code blocks must have a closing fence delimiter.                                 |
 | [MDS032](MDS032-no-empty-alt-text/README.md)                  | `no-empty-alt-text`                  | ready     | Images must have non-empty alt text for accessibility.                                  |
 | [MDS033](MDS033-directory-structure/README.md)                | `directory-structure`                | ready     | Markdown files must exist only in explicitly allowed directories.                       |
-| [MDS036](MDS036-section-size-limits/README.md)                | `section-size-limits`                | ready     | Section length must not exceed per-level or per-heading limits.                         |
+| [MDS036](MDS036-max-section-length/README.md)                 | `max-section-length`                 | ready     | Section length must not exceed per-level or per-heading limits.                         |
 <?/catalog?>
diff --git a/internal/rules/maxsectionlength/rule.go b/internal/rules/maxsectionlength/rule.go
@@ -1,4 +1,4 @@
-package sectionsizelimits
+package maxsectionlength
 
 import (
 	"fmt"
@@ -44,7 +44,7 @@ type HeadingPattern struct {
 func (r *Rule) ID() string { return "MDS036" }
 
 // Name implements rule.Rule.
-func (r *Rule) Name() string { return "section-size-limits" }
+func (r *Rule) Name() string { return "max-section-length" }
 
 // Category implements rule.Rule.
 func (r *Rule) Category() string { return "heading" }
@@ -106,12 +106,12 @@ func (r *Rule) ApplySettings(settings map[string]any) error {
 			n, ok := toInt(v)
 			if !ok {
 				return fmt.Errorf(
-					"section-size-limits: max must be an integer, got %T", v,
+					"max-section-length: max must be an integer, got %T", v,
 				)
 			}
 			if n < 0 {
 				return fmt.Errorf(
-					"section-size-limits: max must be non-negative, got %d", n,
+					"max-section-length: max must be non-negative, got %d", n,
 				)
 			}
 			r.Max = n
@@ -129,7 +129,7 @@ func (r *Rule) ApplySettings(settings map[string]any) error {
 			r.PerHeading = patterns
 		default:
 			return fmt.Errorf(
-				"section-size-limits: unknown setting %q", k,
+				"max-section-length: unknown setting %q", k,
 			)
 		}
 	}
@@ -208,32 +208,32 @@ func parsePerLevel(v any) (map[int]int, error) {
 	raw, err := asStringMap(v)
 	if err != nil {
 		return nil, fmt.Errorf(
-			"section-size-limits: per-level %w", err,
+			"max-section-length: per-level %w", err,
 		)
 	}
 	out := make(map[int]int, len(raw))
 	for k, val := range raw {
 		level, err := strconv.Atoi(k)
 		if err != nil {
 			return nil, fmt.Errorf(
-				"section-size-limits: per-level key %q must be an integer 1-6", k,
+				"max-section-length: per-level key %q must be an integer 1-6", k,
 			)
 		}
 		if level < 1 || level > 6 {
 			return nil, fmt.Errorf(
-				"section-size-limits: per-level key %d out of range (1-6)", level,
+				"max-section-length: per-level key %d out of range (1-6)", level,
 			)
 		}
 		n, ok := toInt(val)
 		if !ok {
 			return nil, fmt.Errorf(
-				"section-size-limits: per-level[%d] must be an integer, got %T",
+				"max-section-length: per-level[%d] must be an integer, got %T",
 				level, val,
 			)
 		}
 		if n < 0 {
 			return nil, fmt.Errorf(
-				"section-size-limits: per-level[%d] must be non-negative", level,
+				"max-section-length: per-level[%d] must be non-negative", level,
 			)
 		}
 		out[level] = n
@@ -245,33 +245,33 @@ func parsePerHeading(v any) ([]HeadingPattern, error) {
 	items, ok := v.([]any)
 	if !ok {
 		return nil, fmt.Errorf(
-			"section-size-limits: per-heading must be a list, got %T", v,
+			"max-section-length: per-heading must be a list, got %T", v,
 		)
 	}
 	settings := make([]patternSetting, 0, len(items))
 	for i, item := range items {
 		m, err := asStringMap(item)
 		if err != nil {
 			return nil, fmt.Errorf(
-				"section-size-limits: per-heading[%d] %w", i, err,
+				"max-section-length: per-heading[%d] %w", i, err,
 			)
 		}
 		pattern, _ := m["pattern"].(string)
 		if pattern == "" {
 			return nil, fmt.Errorf(
-				"section-size-limits: per-heading[%d].pattern must be a non-empty string",
+				"max-section-length: per-heading[%d].pattern must be a non-empty string",
 				i,
 			)
 		}
 		max, ok := toInt(m["max"])
 		if !ok {
 			return nil, fmt.Errorf(
-				"section-size-limits: per-heading[%d].max must be an integer", i,
+				"max-section-length: per-heading[%d].max must be an integer", i,
 			)
 		}
 		if max < 0 {
 			return nil, fmt.Errorf(
-				"section-size-limits: per-heading[%d].max must be non-negative", i,
+				"max-section-length: per-heading[%d].max must be non-negative", i,
 			)
 		}
 		settings = append(settings, patternSetting{Pattern: pattern, Max: max})
@@ -290,7 +290,7 @@ func compilePatterns(in []patternSetting) ([]HeadingPattern, error) {
 		re, err := regexp.Compile(p.Pattern)
 		if err != nil {
 			return nil, fmt.Errorf(
-				"section-size-limits: invalid pattern %q: %w", p.Pattern, err,
+				"max-section-length: invalid pattern %q: %w", p.Pattern, err,
 			)
 		}
 		out = append(out, HeadingPattern{
diff --git a/internal/rules/maxsectionlength/rule_test.go b/internal/rules/maxsectionlength/rule_test.go
@@ -1,4 +1,4 @@
-package sectionsizelimits
+package maxsectionlength
 
 import (
 	"regexp"
@@ -39,7 +39,7 @@ func TestCheck_SectionOverLimit_Diagnostic(t *testing.T) {
 	require.Len(t, diags, 1)
 	d := diags[0]
 	assert.Equal(t, "MDS036", d.RuleID)
-	assert.Equal(t, "section-size-limits", d.RuleName)
+	assert.Equal(t, "max-section-length", d.RuleName)
 	assert.Equal(t, lint.Warning, d.Severity)
 	assert.Equal(t, 1, d.Line)
 	assert.Equal(t, 1, d.Column)
@@ -216,7 +216,7 @@ func TestID(t *testing.T) {
 }
 
 func TestName(t *testing.T) {
-	assert.Equal(t, "section-size-limits", (&Rule{}).Name())
+	assert.Equal(t, "max-section-length", (&Rule{}).Name())
 }
 
 func TestCategory(t *testing.T) {
diff --git a/plan/51_section-level-size-limits.md b/plan/51_section-level-size-limits.md
@@ -27,11 +27,12 @@ to prevent oversized headings from hiding in otherwise compliant files.
 
 ## Notes
 
-Implemented as MDS036 `section-size-limits`. A section spans from its
-heading line up to (but not including) the next heading line of any
-level, or end of file. Nested subsections are measured independently
-of their parent, so the limit applies to direct content under each
-heading. Lookup order for the applicable max: `per-heading` regex
-(first match), `per-level`, `max`. Disabled by default; enable by
-setting `max` (or any `per-level` / `per-heading` entry) to a positive
-integer in `.mdsmith.yml`.
+Implemented as MDS036 `max-section-length` (named to mirror
+`max-file-length`, since limits are measured in lines). A section
+spans from its heading line up to (but not including) the next heading
+line of any level, or end of file. Nested subsections are measured
+independently of their parent, so the limit applies to direct content
+under each heading. Lookup order for the applicable max: `per-heading`
+regex (first match), `per-level`, `max`. Disabled by default; enable
+by setting `max` (or any `per-level` / `per-heading` entry) to a
+positive integer in `.mdsmith.yml`.
