Skip to content

Commit fa552b7

Browse files
committed
docs(plan/145): fix step order and link style in review note (round-3 xhigh)
Round-3 code review (xhigh) found one confirmed factual error and one style issue in the review note: 1. The mise-registry soft-skip description had ::warning:: and skipped=true in the wrong order. Actual release.yml (lines 830-832) emits ::warning:: first, then sets skipped=true in $GITHUB_OUTPUT, then exits 0. Corrected the sequence. 2. The releasesmoke.go Markdown link had backtick-only link text ([`path`](url)), which is unusual. Switched to a prose-symbol label ([`RequiredSmokeChannels`](...)) matching the project's link style. Skipped two candidates as false positives: - "No checkbox updates": all in-repo tasks were already checked off; external-registry items cannot be closed until registries accept. - "Vague 'carry' in last bullet": the registry-status content lives in body prose, not a named frontmatter field — there is no field to cite. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015N68QBoYgieHxfTLqXpRDU
1 parent 81dedaa commit fa552b7

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

plan/145_asdf-mise-registry-submissions.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -157,12 +157,14 @@ verifications:
157157

158158
- `release.yml` smoke-test matrix: the `asdf` channel
159159
install script exits non-zero on failure; the
160-
`mise-registry` channel uses `skipped=true` and
161-
`::warning::` then exits 0 (soft-skip, not gating).
162-
- [`internal/release/releasesmoke.go`](../internal/release/releasesmoke.go)
163-
`RequiredSmokeChannels`: `{"asdf", "go", "mise",
164-
"npm", "pip"}` — includes `"asdf"` and the explicit-URL
165-
`"mise"` form; excludes the bare `"mise-registry"` form.
160+
`mise-registry` channel emits `::warning::`, sets
161+
`skipped=true` in `$GITHUB_OUTPUT`, then exits 0
162+
(soft-skip, not gating).
163+
- [`RequiredSmokeChannels`](../internal/release/releasesmoke.go)
164+
in `internal/release/releasesmoke.go`:
165+
`{"asdf", "go", "mise", "npm", "pip"}` — includes
166+
`"asdf"` and the explicit-URL `"mise"` form; excludes
167+
the bare `"mise-registry"` form.
166168
- `docs/guides/install.md`: "neither registry entry
167169
exists yet" note just below the channel-comparison
168170
table, and per-section notes warning that bare

0 commit comments

Comments
 (0)