Skip to content

Empty scope doesn't fail PR lint action #228

Closed
@wolfm89

Description

@wolfm89

Expected Behavior

A PR with title feat(): My description should fail the action due to missing scope.
The conventional commit specification says:

A scope MAY be provided after a type. A scope MUST consist of a noun describing a section of the codebase surrounded by parenthesis, e.g., fix(parser):

This is also how it's implemented in many other checkers (https://github.com/conventional-changelog/commitlint/blob/28bac3ea619e010ce1a3dbd08502588138ef9b74/%40commitlint/rules/src/scope-empty.test.ts#L35) and regex definitions (https://gist.github.com/marcojahn/482410b728c31b221b70ea6d2c433f0c)

Current Behavior

PR action doesn't fail on empty scope.

Steps to Reproduce

Create a PR with title feat(): My description and run this action on it.

Logs

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions