Invisible comments inside popup menus

[veselyn]

The PMenu highlight group has the same background color as the foreground color of Comment, therefore, comments are "invisible" inside popup menus. This is the case for both of the background options (light or dark).

Would it make sense to swap the Comment highlights between light and dark mode here: https://github.com/jeffkreeftmeijer/vim-dim/blob/main/colors/dim.vim#L26-L54?

---

Light mode

Dark mode

Actual content inside the popup menu

[jeffkreeftmeijer]

Could you show how that would look? I think I’d rather change the background colors of the pmenus than changing the comment colors, but I could be wrong.

[veselyn]

This is how the comments look like in a popup menu with the colors swapped (with background set to dark):

However, outside of the popup menus, the comments blend in with other highlights:

Perhaps it makes more sense to swap the colors of the pmenus instead so the comments can remain with lower contrast.

This is how it looks like for me with them swapped (top picture is with background set to dark):