fixup! Allow disabling of all network accesses

Author: ibbem

History.markdown

@@ -1,9 +1,3 @@
-## HEAD
-
-## Minor Enhancements
-
-  * Disable network related features if the env var `PAGES_DISABLE_NETWORK` is set
-
 ## 2.16.1 / 2023-12-22
 
 ### Bug Fixes

spec/client_spec.rb

@@ -38,4 +38,21 @@
       subject.contributors("jekyll/github-metadata")
     end.to raise_error(described_class::BadCredentialsError)
   end
+
+  before { ENV["PAGES_DISABLE_NETWORK"] = nil }
+
+  it "supresses network accesses if requested" do
+    WebMock.disable_net_connect!
+
+    ENV["PAGES_DISABLE_NETWORK"] = "1"
+    expect(subject.contributors("jekyll/github-metadata")).to be(false)
+  end
+
+  it "allows network accesses by default" do
+    WebMock.disable_net_connect!
+
+    expect do
+      subject.contributors("jekyll/github-metadata")
+    end.to raise_error(WebMock::NetConnectNotAllowedError)
+  end
 end