Skip to content

Commit 9434248

Browse files
committed
fix: Fix tagline not showing without description defined
1 parent 9eb0368 commit 9434248

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

lib/jekyll-seo-tag/drop.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def title
7575
@title ||= begin
7676
if site_title && page_title != site_title
7777
page_title + TITLE_SEPARATOR + site_title
78-
elsif site_description && site_title
78+
elsif site_tagline_or_description && site_title
7979
site_title + TITLE_SEPARATOR + site_tagline_or_description
8080
else
8181
page_title || site_title

spec/jekyll_seo_tag/drop_spec.rb

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,17 @@
109109
end
110110

111111
context "with a site tagline but no page title" do
112+
let(:page) { make_page }
113+
let(:config) do
114+
{ "title" => "site title", "tagline" => "site tagline" }
115+
end
116+
117+
it "builds the title" do
118+
expect(subject.title).to eql("site title | site tagline")
119+
end
120+
end
121+
122+
context "with a site tagline ans description but no page title" do
112123
let(:page) { make_page }
113124
let(:config) do
114125
{ "title" => "site title", "description" => "site description", "tagline" => "site tagline" }

0 commit comments

Comments
 (0)