Delegate cursor auto-hide to jellyfin-web

Removes redundant native cursor hide timer. Now observe's jellyfin-web's
mouseIdle class instead. Should fix intermittent failure to hide cursor
when video is playing.

Author: andrewrabert

native/nativeshell.js

@@ -297,6 +297,18 @@ window.initCompleted = new Promise(async (resolve) => {
             window.sessionStorage.setItem("settingsDescriptions", JSON.stringify(jmpInfo.settingsDescriptions));
         }
     );
+
+    // Sync cursor visibility with jellyfin-web's mouse idle state
+    const observer = new MutationObserver((mutations) => {
+        for (const mutation of mutations) {
+            if (mutation.attributeName === 'class') {
+                const isIdle = document.body.classList.contains('mouseIdle');
+                window.api.system.setCursorVisibility(!isIdle);
+            }
+        }
+    });
+    observer.observe(document.body, { attributes: true, attributeFilter: ['class'] });
+
     resolve();
 });
 

src/system/SystemComponent.cpp

@@ -31,7 +31,6 @@
 #include "utils/Utils.h"
 #include "utils/Log.h"
 
-#define MOUSE_TIMEOUT 5 * 1000
 
 #define KONVERGO_PRODUCTID_DEFAULT  3
 #define KONVERGO_PRODUCTID_OPENELEC 4
@@ -58,10 +57,6 @@ QMap<SystemComponent::PlatformArch, QString> g_platformArchNames = {
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 SystemComponent::SystemComponent(QObject* parent) : ComponentBase(parent), m_platformType(platformTypeUnknown), m_platformArch(platformArchUnknown), m_doLogMessages(false), m_cursorVisible(true), m_scale(1), m_connectivityCheckReply(nullptr), m_resolveUrlReply(nullptr)
 {
-  m_mouseOutTimer = new QTimer(this);
-  m_mouseOutTimer->setSingleShot(true);
-  connect(m_mouseOutTimer, &QTimer::timeout, [&] () { setCursorVisibility(false); });
-
   m_connectivityRetryTimer = new QTimer(this);
   m_connectivityRetryTimer->setSingleShot(true);
   connect(m_connectivityRetryTimer, &QTimer::timeout, [this]() {
@@ -440,12 +435,10 @@ void SystemComponent::setCursorVisibility(bool visible)
   if (visible)
   {
     qApp->restoreOverrideCursor();
-    m_mouseOutTimer->start(MOUSE_TIMEOUT);
   }
   else
   {
     qApp->setOverrideCursor(QCursor(Qt::BlankCursor));
-    m_mouseOutTimer->stop();
   }
 
 #ifdef Q_OS_MAC

src/system/SystemComponent.h

@@ -131,7 +131,6 @@ private Q_SLOTS:
   QSslConfiguration getSSLConfiguration();
   void setReplyTimeout(QNetworkReply* reply, int ms);
 
-  QTimer* m_mouseOutTimer;
   QNetworkAccessManager* m_networkManager;
   PlatformType m_platformType;
   PlatformArch m_platformArch;

src/ui/EventFilter.cpp

@@ -3,7 +3,6 @@
 //
 
 #include "EventFilter.h"
-#include "system/SystemComponent.h"
 #include "settings/SettingsComponent.h"
 #include "input/InputKeyboard.h"
 #include <QQuickWindow>
@@ -119,8 +118,6 @@ bool EventFilter::eventFilter(QObject* watched, QEvent* event)
     return QObject::eventFilter(watched, event);
   }
 
-  SystemComponent& system = SystemComponent::Get();
-
   // ignore mouse events if mouse is disabled
   if  (SettingsComponent::Get().value(SETTINGS_SECTION_MAIN, "disablemouse").toBool() &&
        ((event->type() == QEvent::MouseMove) ||
@@ -172,17 +169,12 @@ bool EventFilter::eventFilter(QObject* watched, QEvent* event)
     else
       m_currentKeyDown = false;
 
-    system.setCursorVisibility(false);
     if (kevent->spontaneous() && !kevent->isAutoRepeat())
     {
       InputKeyboard::Get().keyPress(keyName, keystatus);
       return true;
     }
   }
-  else if (event->type() == QEvent::MouseMove)
-  {
-    system.setCursorVisibility(true);
-  }
   else if (event->type() == QEvent::Wheel)
   {
     return true;