Merge pull request #1100 from jellyfin/macos_cursor

Fix macos cursor hiding when outside of Jellyfin Desktop

Author: andrewrabert

CMakeModules/AppleConfiguration.cmake

@@ -6,7 +6,7 @@ find_Library(CARBON Carbon)
 find_library(SECURITY Security)
 find_library(MEDIAPLAYER MediaPlayer)
 
-set(OS_LIBS ${FOUNDATION} ${APPKIT} ${IOKIT} ${COCOA} ${SECURITY} ${CARBON} hidremote plistparser letsmove)
+set(OS_LIBS ${FOUNDATION} ${APPKIT} ${IOKIT} ${COCOA} ${SECURITY} ${CARBON} hidremote letsmove)
 set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -framework MediaPlayer")
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mmacosx-version-min=10.15 -fno-omit-frame-pointer")

CMakeModules/CompilerFlags.cmake

@@ -10,6 +10,8 @@ if(NOT MSVC)
   enable_if_supported(COMPILER_FLAGS "-Wmissing-include-dirs")
   enable_if_supported(COMPILER_FLAGS "-Woverloaded-virtual")
   enable_if_supported(COMPILER_FLAGS "-Wold-style-cast")
+  enable_if_supported(COMPILER_FLAGS "-Wsign-compare")
+  enable_if_supported(COMPILER_FLAGS "-Wdeprecated-declarations")
 endif()
 
 enable_if_supported(COMPILER_FLAGS "-Wshorten-64-to-32")

external/CMakeLists.txt

@@ -2,7 +2,6 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${COMPILER_FLAGS_THIRD_PARTY}")
 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${COMPILER_FLAGS_THIRD_PARTY}")
 
 if(APPLE)
-  add_subdirectory(plistparser)
   add_subdirectory(HIDRemote)
   add_subdirectory(letsmove)
 endif(APPLE)

external/plistparser/CMakeLists.txt

@@ -172,12 +172,7 @@ class inputPlugin {
 
                 const state = playbackManager.getPlayerState();
                 if (state && state.NowPlayingItem) {
-                    let serverAddress = '';
-                    if (window.ApiClient && typeof window.ApiClient.serverAddress === 'function') {
-                        serverAddress = window.ApiClient.serverAddress();
-                    }
-
-                    api.player.notifyMetadata(state.NowPlayingItem, serverAddress || '');
+                    api.player.notifyMetadata(state.NowPlayingItem);
 
                     const initialPos = playbackManager.currentTime();
                     if (initialPos !== undefined && initialPos !== null) {