Skip to content

Commit cfe832a

Browse files
committed
Ignore backdrop images and don't read poster button images
1 parent 696d995 commit cfe832a

5 files changed

Lines changed: 11 additions & 0 deletions

File tree

Swiftfin/Components/PosterButton.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ struct PosterButton<Item: Poster>: View {
6363
.backport
6464
.matchedTransitionSource(id: "item", in: namespace)
6565
.posterShadow()
66+
.accessibilityElement(children: .ignore)
6667

6768
label
6869
.eraseToAnyView()

Swiftfin/Views/ItemView/ScrollViews/CinematicScrollView.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ extension ItemView {
5353
.aspectRatio(usePrimaryImage ? (2 / 3) : 1.77, contentMode: .fill)
5454
.frame(width: proxy.size.width, height: proxy.size.height * 0.6)
5555
.bottomEdgeGradient(bottomColor: bottomColor)
56+
.accessibilityHidden(true)
5657
}
5758
}
5859
}
@@ -114,6 +115,8 @@ extension ItemView.CinematicScrollView {
114115
}
115116
.aspectRatio(contentMode: .fit)
116117
.frame(height: 100, alignment: .bottom)
118+
.accessibilityElement(children: .ignore)
119+
.accessibilityLabel(viewModel.item.displayTitle)
117120
}
118121

119122
DotHStack {

Swiftfin/Views/ItemView/ScrollViews/CompactLogoScrollView.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ extension ItemView {
3838
.aspectRatio(1.77, contentMode: .fill)
3939
.frame(width: proxy.size.width, height: proxy.size.height * 0.70, alignment: .top)
4040
.bottomEdgeGradient(bottomColor: bottomColor)
41+
.accessibilityHidden(true)
4142
}
4243
}
4344

@@ -103,6 +104,8 @@ extension ItemView.CompactLogoScrollView {
103104
}
104105
.aspectRatio(contentMode: .fit)
105106
.frame(height: 70, alignment: .bottom)
107+
.accessibilityElement(children: .ignore)
108+
.accessibilityLabel(viewModel.item.displayTitle)
106109

107110
DotHStack {
108111
if let firstGenre = viewModel.item.genres?.first {

Swiftfin/Views/ItemView/ScrollViews/CompactPortraitScrollView.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ extension ItemView {
6161
.aspectRatio(1.77, contentMode: .fill)
6262
.frame(width: proxy.size.width, height: proxy.size.height * 0.78, alignment: .top)
6363
.bottomEdgeGradient(bottomColor: bottomColor)
64+
.accessibilityHidden(true)
6465
}
6566
}
6667
}

Swiftfin/Views/ItemView/ScrollViews/iPadOSCinematicScrollView.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ extension ItemView {
5959
ImageView(imageSource)
6060
.aspectRatio(1.77, contentMode: .fill)
6161
.bottomEdgeGradient(bottomColor: bottomColor)
62+
.accessibilityHidden(true)
6263
}
6364
}
6465

@@ -121,6 +122,8 @@ extension ItemView.iPadOSCinematicScrollView {
121122
}
122123
.aspectRatio(contentMode: .fit)
123124
.frame(maxWidth: geometry.size.width * 0.4, maxHeight: 130, alignment: .bottomLeading)
125+
.accessibilityElement(children: .ignore)
126+
.accessibilityLabel(viewModel.item.displayTitle)
124127

125128
ItemView.OverviewView(item: viewModel.item)
126129
.overviewLineLimit(3)

0 commit comments

Comments
 (0)