Skip to content

fix: the responses to several requests returns erroneous values#117

Closed
FelixPetriconi wants to merge 6 commits intojellyfin:masterfrom
FelixPetriconi:bugfix/contentdirectory-event-failure-response
Closed

fix: the responses to several requests returns erroneous values#117
FelixPetriconi wants to merge 6 commits intojellyfin:masterfrom
FelixPetriconi:bugfix/contentdirectory-event-failure-response

Conversation

@FelixPetriconi
Copy link
Copy Markdown
Contributor

The comparison of the several responses with DLNA complaint servers has shown differences and were fixed accordingly

Please bare with me but I don't know much about C# or the used frameworks. Please advise how to improve the code if necessary.

I just can tell that now my Panasonic Blu-Ray player is able to connect to the Jellyfin instance.
The display of photos, streaming of mp3 and flac, and some mpg works fine.
I intent to add a working profile for that player as soon as I have found out how to get .mkv container playing.

* the comparison of the several responses with DLNA complaint servers
  has shown differences and were fixed accordingly
Comment thread src/Jellyfin.Plugin.Dlna/Api/DlnaServerController.cs Fixed
Copy link
Copy Markdown

@DSLinuxUser DSLinuxUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried today the updates and now the Panasonic DMR-BCT750/755 is able to connect to JellyFin and plays videos back.

@FelixPetriconi
Copy link
Copy Markdown
Contributor Author

Which profile did you use? What kind of videos container did you play back?

@crobibero
Copy link
Copy Markdown
Member

I don't see how this would work as the response isn't being set to anything.

@FelixPetriconi
Copy link
Copy Markdown
Contributor Author

I cannot give you an answer to this, because I don't much about the used framework. I only can say that a response that is set to any mime type is a) not been accepted by the Panasonic player and b) it has now with this changes same result as with e.g. Emby 4.8.10 and Twonky Server 8.5.2.
I checked it on protocol level with Wireshark.

@DSLinuxUser
Copy link
Copy Markdown

Which profile did you use? What kind of videos container did you play back?

What kind of profile do you mean? Device profile?
If device profile, Jellyfin tells me in the log, that the default profile is selected.

Test was done MP4 with H264/AAC.

I don't see how this would work as the response isn't being set to anything.

Well, before this patch, the Panasonic would just throw the error "Unable to connect to server".
With this patch, it just works.

@FelixPetriconi
Copy link
Copy Markdown
Contributor Author

The same for me now.

Copy link
Copy Markdown

@DSLinuxUser DSLinuxUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the changes, recompiled and replaced the DLLs and the Panasonic can still access JellyFin.

@disgustipated
Copy link
Copy Markdown
Contributor

It looks like this is taking the response and adding/modifying some headers to the packet. Is that correct? What is the SID? Theres a System import that I'm not sure is needed. I'll test this out this week to see if I can get other devices to work as expected too.

@FelixPetriconi
Copy link
Copy Markdown
Contributor Author

I don't know much about Jellyfin or the DLNA plugin but I assume it is a session ID that is generated by the DLNA plugin and that helps to associate future request of that DLNA client to a certain session context.

@zznty
Copy link
Copy Markdown

zznty commented Mar 14, 2025

Thank you, building from this pr has fixed jellyfin discovery in both vlc and good old lg smart tv.

FelixPetriconi and others added 4 commits March 14, 2025 21:00
@FelixPetriconi
Copy link
Copy Markdown
Contributor Author

Are there problems with this PR? If so, please let me know.
Keeping PRs that long open cause automatically problems. I just solved the new conflicts.

@DSLinuxUser
Copy link
Copy Markdown

Are there problems with this PR? If so, please let me know. Keeping PRs that long open cause automatically problems. I just solved the new conflicts.

For me these changes fixed the issue and I approved the PR.
At least I think I did:
image

@Shadowghost
Copy link
Copy Markdown
Contributor

I wonder if these modifications should not be moved to the handler itself instead of the controller

@ypopovych
Copy link
Copy Markdown

Hello.

Will this PR be merged?

@crobibero
Copy link
Copy Markdown
Member

Releasing for 10.10 isn't an easy task when 10.11 is in RC phase. As such I've created a PR with these commits along with some cleanup to #166 and merged into unstable.

@crobibero crobibero closed this Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants