Strip URL parameters (#25)

[bchretien]

Hi,

This is a PR containing a patch listed in #25 to make the DLNA plugin work with the Orange TV Decoder. From my understanding, it strips URL parameters. I'm not sure of the impact for the rest of the DLNA clients as they may rely on the URL parameters. Maybe a per-profile option to strip these parameters would be more suitable?

[Shadowghost]

I think this would make more sense to move this check to L440/441:

return ext.AsSpan().LeftPart('?').ToString();

From what I can see this change shouldn't break anything.

[Vebryn]

@bchretien Shadowghost suggest to move line to L440. Hope it will be ok to merge. Best regards

[dadodasyra]

@bchretien can you take a look at the suggested changes so the pr can be merged ?

[dadodasyra]

I tried to build and use your version.
It seems to fix in some cases the usage of jellyfin through Orange UHD decoder (which in fact corresponds to a "soft at home" player: DeviceIdentification { FriendlyName: "Décodeur TV UHD", ModelNumber: "1.7.19", SerialNumber: "82516178", ModelName: "SoftAtHome Media Renderer", ModelDescription: "DLNA 1.5 Compliant Media Renderer from SoftAtHome", ModelUrl: "http://www.softathome.com", Manufacturer: "SoftAtHome", ManufacturerUrl: "http://www.softathome.com", Headers: [] })

But multiple issues:

• No control over the video, I can't see the
  time and cannot navigate through time.
• No subs or audio control (tough it seems the player seems to support it)
• Sometime the whole video decoding crashes, the decoder needs to be fully rebooted to work again (even the TV doesn't shows up anymore): this seems not a new issue as I saw some orange forums posts about it.
• Most of my "videos" doesn't work even if their format are similar (take a look at the linked document where I list some that was working and some that were not).
  WorkingNotworking.txt

It's probably the fault of orange/softathome bad software but if anybody has any idea on how to find a better alternative..

Here's logs, (Moana works, mufasa doesn't):

[2025-02-07 16:53:52.832 +00:00] [ERR] Error processing control request
MediaBrowser.Common.Extensions.ResourceNotFoundException: Unexpected control request name: GetCurrentConnectionIDs
   at Jellyfin.Plugin.Dlna.ConnectionManager.ControlHandler.WriteResult(String methodName, IReadOnlyDictionary2 methodParams, XmlWriter xmlWriter)
   at Jellyfin.Plugin.Dlna.Service.BaseControlHandler.CreateControlResponse(ControlRequestInfo requestInfo)
   at Jellyfin.Plugin.Dlna.Service.BaseControlHandler.ProcessControlRequestInternalAsync(ControlRequest request)
   at Jellyfin.Plugin.Dlna.Service.BaseControlHandler.ProcessControlRequestAsync(ControlRequest request)
[2025-02-07 16:53:53.043 +00:00] [INF] No matching device profile found. The default will need to be used. 
DeviceIdentification { FriendlyName: "Décodeur TV UHD", ModelNumber: "1.7.19", SerialNumber: "82516178", ModelName: "SoftAtHome Media Renderer", ModelDescription: "DLNA 1.5 Compliant Media Renderer from SoftAtHome", ModelUrl: "http://www.softathome.com", Manufacturer: "SoftAtHome", ManufacturerUrl: "http://www.softathome.com", Headers: [] }
[2025-02-07 16:53:53.043 +00:00] [INF] DLNA Session created for "Décodeur TV UHD" - "SoftAtHome Media Renderer" using profile "Generic Device"
[2025-02-07 16:53:58.583 +00:00] [INF] "/usr/lib/jellyfin-ffmpeg/ffmpeg" "-analyzeduration 200M -probesize 1G -fflags +genpts  -i file:\"/hdd/jellyfin/movies/Moana 2 (2024) [tmdbid-1241982]/Moana 2 (2024) [tmdbid-1241982] - [WEBDL-1080p][EAC3 5.1][h264]-SUPPLY.mkv\" -map 0:0 -map 0:1 -map -0:s -codec:v:0 copy -map_metadata -1 -map_chapters -1 -threads 6 -codec:a:0 libfdk_aac -ac 6 -ab 768000 -y \"/var/cache/jellyfin/transcodes/56df20fcb9a4c112915ff42a08121316.mkv\""
[2025-02-07 16:54:16.193 +00:00] [INF] "/usr/lib/jellyfin-ffmpeg/ffmpeg" "-analyzeduration 200M -probesize 1G -fflags +genpts  -i file:\"/hdd/jellyfin/movies/Mufasa The Lion King (2024) [tmdbid-762509]/Mufasa The Lion King (2024) [tmdbid-762509] - [WEBRip-1080p][AAC 2.0][x264]-YTS.MX.mp4\" -map 0:0 -map 0:1 -map -0:s -codec:v:0 copy -map_metadata -1 -map_chapters -1 -threads 6 -codec:a:0 libfdk_aac -ac 2 -ab 256000 -y \"/var/cache/jellyfin/transcodes/b614ff37858a034170336afde7f9f03a.mov\""
[2025-02-07 16:54:27.332 +00:00] [INF] Transcoding kill timer stopped for JobId "7ed0669c7fd140de8c301e58df63c629" PlaySessionId null. Killing transcoding
[2025-02-07 16:54:27.332 +00:00] [INF] Stopping ffmpeg process with q command for "/var/cache/jellyfin/transcodes/b614ff37858a034170336afde7f9f03a.mov"
[2025-02-07 16:54:27.777 +00:00] [INF] FFmpeg exited with code 0
[2025-02-07 16:54:27.777 +00:00] [INF] Deleting partial stream file(s) "/var/cache/jellyfin/transcodes/b614ff37858a034170336afde7f9f03a.mov" 

[Shadowghost]

Fixed by #137