Skip to content

Trying to download deleted subtitles misses relevant log information #146

@keinezeit8

Description

@keinezeit8

I have the plugin running on a regular interval but it has stopped downloading for a while now. Manual downloads still work.

I get the following error message in the logs

[2024-08-04 20:36:11.630 +02:00] [ERR] [63] MediaBrowser.Providers.MediaInfo.SubtitleScheduledTask: Error downloading subtitles
System.Net.Http.HttpRequestException: Subtitle with Id 297659 could not be downloaded: OK
   at Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader.GetSubtitlesInternal(String id, CancellationToken cancellationToken)
   at MediaBrowser.Providers.Subtitles.SubtitleManager.DownloadSubtitles(Video video, LibraryOptions libraryOptions, String subtitleId, CancellationToken cancellationToken)
   at MediaBrowser.Providers.MediaInfo.SubtitleDownloader.DownloadSubtitles(Video video, List`1 mediaStreams, Boolean skipIfEmbeddedSubtitlesPresent, Boolean skipIfAudioTrackMatches, Boolean requirePerfectMatch, String language, String[] disabledSubtitleFetchers, String[] subtitleFetcherOrder, VideoContentType mediaType, Boolean isAutomated, CancellationToken cancellationToken)

It makes sense that this request fails since the subtitles with that ID have been deleted.
https://www.opensubtitles.com/en/subtitles/297659
Unfortunately there is no easy way to find out what episode/movie was the problem and I am not sure, but I believe that the plugin crashes completely and stops downloading other subtitles.

Solutions in preferred order:

  1. Plugin can work around deleted content
  2. Plugin skips deleted content and mentions the problematic media in the logs
  3. Plugin stops and mentions the problematic media in the logs

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions